From owner-svn-src-head@freebsd.org  Fri Nov 30 19:53:23 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2047E114E414;
 Fri, 30 Nov 2018 19:53:23 +0000 (UTC)
 (envelope-from arybchik@FreeBSD.org)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [84.52.114.115])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8C3D77311A;
 Fri, 30 Nov 2018 19:53:22 +0000 (UTC)
 (envelope-from arybchik@FreeBSD.org)
Received: from [192.168.1.192] (unknown [188.242.181.57])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 6C61E7F5DF;
 Fri, 30 Nov 2018 22:53:20 +0300 (MSK)
Subject: Re: svn commit: r341327 - head/sys/dev/sfxge
To: cem@freebsd.org
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
References: <201811300711.wAU7B5R6084752@repo.freebsd.org>
 <d60f54ae-a1a6-bad5-73f0-c898d0579089@FreeBSD.org>
 <7545b110-4930-d49f-f99f-7ec17db7e7a7@oktetlabs.ru>
 <CAG6CVpWRrGox-sMhWbc6==EPoWoJwzHCnC0xfRbvSwYjhSwXyA@mail.gmail.com>
From: Andrew Rybchenko <arybchik@FreeBSD.org>
Organization: OKTET Labs
Message-ID: <b08b0398-f06d-c3c7-c8d1-664d9b2ca1cd@oktetlabs.ru>
Date: Fri, 30 Nov 2018 22:53:19 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <CAG6CVpWRrGox-sMhWbc6==EPoWoJwzHCnC0xfRbvSwYjhSwXyA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-Rspamd-Queue-Id: 8C3D77311A
X-Spamd-Result: default: False [0.59 / 15.00];
 local_wl_from(0.00)[FreeBSD.org];
 NEURAL_HAM_MEDIUM(-0.15)[-0.153,0];
 NEURAL_SPAM_SHORT(0.56)[0.565,0];
 NEURAL_SPAM_LONG(0.17)[0.173,0];
 ASN(0.00)[asn:25408, ipnet:84.52.64.0/18, country:RU]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Nov 2018 19:53:23 -0000

Hi Conrad,

On 30.11.2018 21:35, Conrad Meyer wrote:
> On Fri, Nov 30, 2018 at 10:16 AM Andrew Rybchenko <arybchik@freebsd.org> wrote:
>> Basically I'm ready to follow any sensible policy.
> Hi Andrew,
>
> I think general policy is to not include a "Differential Revision:"
> line in a commit message unless there was actual review there.

I've not heard about it and have not found it anywhere written.
At least it is convenient to specify, since it closes the review
request automatically and keeps the track. So, I think it is better
to specify, but I have no strong opinion.

> (That's separate from the issue of creating a bunch of reviews that no
> one will ever look at — which is a different kind of spam.)
>
>> Yes in this particular case these 2 hundreds of patches is the result of 2 years of development.
> Why are they being committed now, hundreds at a time, instead of as
> they were developed over the last two years?

It is simple - had no time and had different priorities from SF.
Also there are some benefits in delay - patches are more clear now
since many fixes are squashed in. In any case I'll try to avoid so
huge delays in the future.

Andrew.