From owner-svn-src-all@freebsd.org Thu Oct 8 16:24:33 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C62E39D2E50; Thu, 8 Oct 2015 16:24:33 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cloud.theravensnest.org", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A60CC90; Thu, 8 Oct 2015 16:24:32 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from c124.sec.cl.cam.ac.uk (c124.sec.cl.cam.ac.uk [128.232.18.124]) (authenticated bits=0) by theravensnest.org (8.15.2/8.15.2) with ESMTPSA id t98GOUi1006482 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 8 Oct 2015 16:24:30 GMT (envelope-from theraven@FreeBSD.org) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r289027 - head/contrib/tzcode/stdtime From: David Chisnall In-Reply-To: <561666CE.1050608@FreeBSD.org> Date: Thu, 8 Oct 2015 17:24:29 +0100 Cc: Craig Rodrigues , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Content-Transfer-Encoding: quoted-printable Message-Id: <51F19592-19C7-4444-81BC-9F7DCE74F919@FreeBSD.org> References: <201510081142.t98BgFJd028821@repo.freebsd.org> <561666CE.1050608@FreeBSD.org> To: Andriy Gapon X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 16:24:33 -0000 On 8 Oct 2015, at 13:51, Andriy Gapon wrote: >=20 > What if one day github disappears but FreeBSD is still going? > The full commit message would be lost. That=E2=80=99s not the only thing that is bad about this commit message. = Why =E2=80=98Assume C89?=E2=80=99 We compile libc as C99 + GNU = extensions and are likely to default to C11 + GNU extensions soon. = Reading the actual commit, it looks as if it=E2=80=99s changing K&R = declarations to ISO C declarations. =20 It=E2=80=99s also introducing an ATTRIBUTE_PURE macro in private.h, = which does exactly the same as __pure declared in sys/cdefs.h (which is = included by *every single FreeBSD header*. Why this extra spelling? No = idea. Is this contrib code (it looks like it)? If so, it should come = in via the vendor area (not be directly committed to head), if not then = it should have been code reviewed and not include redundant and = confusing macro declarations. When merging stuff from GitHub, Alfred has written some good = documentation about how to handle them in such a way that we preserve = the prior commit history (effectively, checkout the pr branch, rebase it = on head, git svn dcommit the result). Please follow this procedure. David