From nobody Sat Oct 4 13:29:11 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cf5wX037Vz6Bc5Z; Sat, 04 Oct 2025 13:29:16 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cf5wW6V9sz3qsD; Sat, 04 Oct 2025 13:29:15 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759584555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xCEmmjwON4pHnIxT54tZ8OljFN4u0nUgEkrDL+Bqpdw=; b=Y5cPvUFHCxbxS1DdaoFYVYUhL358NUPcsD33UJ5H+1++Xg80kYYhMbeuT/oT0Vlpl2x01S Oo6E6eHKVQAX6RuE/84YFDkHmhgVu7gb8tATiFp0PrQdNqlNK6AH6GMnJixo8HI5VfPrIY 4UBaBb32SkclbshK/eAOb9ZRX5iaSqtR1TBx7Rcya4GU5ff5oiVq9B623i6fyM870SA+Tb nsX3/8OSrXcraAsxzLJDH4/fMGIph616pmRNyCCFpH7qGMcJzyA031ixDDUrbh7GYw4+Cw +xTA5O3VfWAW5ziECpknxPGWtcRI9Zd3OecSdADDp0X55xNffCjm/SSCqRU4yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759584555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xCEmmjwON4pHnIxT54tZ8OljFN4u0nUgEkrDL+Bqpdw=; b=h5/5dw1PxH8O7ThuJMmDkXWz6CAIrU+uFb/rsi0d9Os0m7kW2QMz9AXSB50teSeRLPATTI L9DaT1SVKD8NKiArG4ynS55gX89qyCTcpSwV7HAZkXuiJpVPFPWzC4kqqUa/bHYf//Xwto zlVUmNEMurrGlIWShldr920fMBgGiSDfWvJFtKma2F4A1s6OsUo3hRwJwWlCL5IlL8Geuv +dRRP9qqYr4J12G/M2rO3hEALYGi7H1tnR5da1MRdZvFFLoqMSgDt3ZqwDcY5RXc1FBwLp +B6jsi0n2otT20czS0cGzeB1oHT5se3qvP9JeorwDS9mFNrOAaTQEho2HfchDg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759584555; a=rsa-sha256; cv=none; b=CoWjqVqFnd7IZq2vcY5KNE9hh9xYuw/CRCjF5+S+BsWvpsBFOgaUxCo2tMMtGFOoXg5wOq gM4zXd8v/EB7G0Dp5qUDm/V0S1BzNYMENvq04uLmi2o9KUnzKQ7UwaHYI7iB41lc46zDHP 4PNod7CFXOCt1ReRw2mKvxv3KgMA8v5AcRlfwDUD5Xuc4vQhKmnnuKfb7eQAqxRjl9QikL d7dC+eJc0gpoLB90Qlkn4NZA4+fWbhfjHy7jxs7AEss19n7tBfLVmWVHzJmUZTvwEfV0lj 89u7ZXp0GEf+Zyq2/Kb4zCE1xyAlvRdvdR2FYt81pbxXh/GFP0XBWJ1K49CMVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R11" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cf5wW5BcBzmS6; Sat, 04 Oct 2025 13:29:15 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 350D515B7A; Sat, 04 Oct 2025 15:29:13 +0200 (CEST) From: Kristof Provost To: Florian Smeets Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 9dfc5e03da50 - main - pfctl: allow tables to be defined inside anchors Date: Sat, 04 Oct 2025 15:29:11 +0200 X-Mailer: MailMate (2.0r6272) Message-ID: <46127FD9-D4F4-4E65-A775-A301070C9FB3@FreeBSD.org> In-Reply-To: <98515e3d-24ba-402e-b2c1-09e30cafeade@smeets.xyz> References: <202509171415.58HEFdN0010140@gitrepo.freebsd.org> <98515e3d-24ba-402e-b2c1-09e30cafeade@smeets.xyz> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 4 Oct 2025, at 9:45, Florian Smeets wrote: > On 17.09.25 16:15, Kristof Provost wrote: >> The branch main has been updated by kp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D9dfc5e03da50d12f02c2b48= 1139acf9f089d504f >> >> commit 9dfc5e03da50d12f02c2b481139acf9f089d504f >> Author: Kristof Provost >> AuthorDate: 2025-08-22 11:34:39 +0000 >> Commit: Kristof Provost >> CommitDate: 2025-09-17 14:15:13 +0000 >> >> pfctl: allow tables to be defined inside anchors >> > Hi Kristof, > > this change prevents pf.conf to load on one of my servers. It works fin= e with 3d14cc82d7a8, but does not with any versions after. Just replacing= pfctl with a version before 9dfc5e03da50 makes it work again. > > Tests on latest main: > > # pfctl -f /etc/pf.conf > pfctl: failed to create table __automatic_d63f3745_0 in : Device busy > > Disabling the optimizer works around the issue. > > # pfctl -o none -f /etc/pf.conf && echo $? > 0 > > I was able to find a simple repro case. > > Take this ruleset: > > --- > ext_if=3D"igb0" > > host_ipv4=3D"192.168.0.1" > host_ipv6=3D"3333:444:222:1843::2" > mail=3D"3333:444:222:1843::25:3" > db=3D"3333:444:222:1843::3306:5" > db4=3D"3333:444:222:1843::3306:4" > web=3D"3333:444:222:1843::80:6" > amavis=3D"3333:444:222:1843::aa:4" > > rdr-anchor "rdr/*" > > block in > pass out > > # anti lockout during tests > pass in on $ext_if proto tcp to ($ext_if) port ssh > > pass in on $ext_if proto tcp to { $host_ipv4, $host_ipv6, $mail, $amavi= s, $db, $db4, $web } port ssh > --- > > It can be successfully loaded without disabling the optimizer if either= removing the 7th element from the second pass in ssh rule ($web in this = case) or disabling the 'rdr-anchor "rdr/*"' line > Thanks for the report, and especially the test case. I=E2=80=99ll add thi= s to my todo list for next week. =E2=80=94 Kristof