From owner-freebsd-net@FreeBSD.ORG  Thu Oct 25 14:50:05 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id BAF7E5F3
 for <freebsd-net@freebsd.org>; Thu, 25 Oct 2012 14:50:05 +0000 (UTC)
 (envelope-from eric@vangyzen.net)
Received: from aussmtpmrkpc120.us.dell.com (aussmtpmrkpc120.us.dell.com
 [143.166.82.159])
 by mx1.freebsd.org (Postfix) with ESMTP id 8BF738FC08
 for <freebsd-net@freebsd.org>; Thu, 25 Oct 2012 14:50:05 +0000 (UTC)
X-Loopcount0: from 64.238.244.148
X-IronPort-AV: E=Sophos;i="4.80,648,1344229200"; 
   d="scan'208";a="8199081"
Message-ID: <5089519B.9060801@vangyzen.net>
Date: Thu, 25 Oct 2012 09:50:03 -0500
From: Eric van Gyzen <eric@vangyzen.net>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:14.0) Gecko/20120822 Thunderbird/14.0
MIME-Version: 1.0
To: freebsd-net@freebsd.org
Subject: Re: [patch] Review: Fix Tahi "Redirected On-link" Test Case
References: <50857210.3090200@vangyzen.net>
In-Reply-To: <50857210.3090200@vangyzen.net>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Oct 2012 14:50:05 -0000

On 10/22/2012 11:19, Eric van Gyzen wrote:
> Bjoern and net@:
>
> I would appreciate your review and comments on the following patches.
>
> http://vangyzen.net/FreeBSD/patches/redir_onlink_8_rev1.diff
> http://vangyzen.net/FreeBSD/patches/redir_onlink_9_rev1.diff
> http://vangyzen.net/FreeBSD/patches/redir_onlink_10_rev1.diff
>
> Thanks in advance,
>
> Eric
>
> ====
>
> Fix the Redirected On-Link test cases in the Tahi IPv6 Ready Logo 
> Phase 2 test suite.
>
> On receipt of a redirect message, install an interface route for the 
> redirected destination.  On removal of the corresponding Neighbor 
> Cache entry, remove the interface route.
>
> This requires changes in rtredirect_fib() to cope with an AF_LINK 
> address for the gateway and with the absence of RTF_GATEWAY.
>
> Unrelated to the above, fix a recursion on the radix node head lock 
> triggered by the Redirected to Alternate Router test cases.
>
> All Section 2 (Neighbor Discovery) test cases pass on 10-CURRENT and 
> 9-STABLE.  (8-STABLE pending)

All Section 2 (Neighbor Discovery) test cases pass on 8-STABLE, too.

To clarify, the following test cases all passed.

> Other test cases:
>
> * the RTF_MODIFIED case, with IPv4 and IPv6 (using a 
> RTF_HOST|RTF_GATEWAY route for the destination)
>
> * the redirected-to-self case, with IPv4 and IPv6
>
> * a valid IPv4 redirect
>
> All testing was done with WITNESS and INVARIANTS.
>
> Submitted by:    Eric van Gyzen <eric % vangyzen : net>,
>                             Mark Kelley <Mark.Kelley % compellent : com>,
>                             Terence Telkamp <Terence_Telkamp % dell : 
> com>
> Sponsored by:    Dell, Inc.
> PR:                        kern/152791