From owner-freebsd-amd64@FreeBSD.ORG Mon Mar 2 10:18:03 2009 Return-Path: Delivered-To: freebsd-amd64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D04C9106564A; Mon, 2 Mar 2009 10:18:03 +0000 (UTC) (envelope-from freebsd@abv.bg) Received: from smtp-out.abv.bg (smtp-out.abv.bg [194.153.145.80]) by mx1.freebsd.org (Postfix) with ESMTP id 7F5DE8FC1D; Mon, 2 Mar 2009 10:18:03 +0000 (UTC) (envelope-from freebsd@abv.bg) Received: from mail53.abv.bg (mail53.ni.bg [192.168.151.29]) by smtp-out.abv.bg (Postfix) with ESMTP id CD2D887ABD; Mon, 2 Mar 2009 12:18:01 +0200 (EET) DomainKey-Signature: a=rsa-sha1; s=smtp-out; d=abv.bg; c=simple; q=dns; b=CoHuaLX9gIaWAYtjGKoW3KNZ6R/L7TzI7RW3eRPLiiYepDFCOwYVCKbfIL/0oS2qo qwV39XEZlGdtKdprqw6JFgoTvJ2q94RMsfKXaL4H3caY0cjF6s6TFMR5JG8HUI7iS5P rzIcxEuL4pQpEYlGTeS4tMO4KZTuePPyPDg1uVM= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=abv.bg; s=smtp-out; t=1235989081; bh=Wejqlzen8BPwRaetzw9DORFh4ggHeMyXK7gfWlWtplw=; h=Date:From:To:Cc:Message-ID:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:DKIM; b=njk2DfKjr26WteQC/MrLcz6WLK6LddhX 6ATKpWF89VIEqMR5wqDuQmNymjOA7WQZzlongogjAxid13g5IYYSxmAWNdb2IjRBXBj ZR+8PmlVaLP7Dzl4Zfdt78Ny1I+nSCoLjgrbADzNWUWCiynqXTP6ifvYc1AW65oWfHj 58dms= Received: from mail53.abv.bg (localhost.localdomain [127.0.0.1]) by mail53.abv.bg (Postfix) with ESMTP id 302251E4B0A; Mon, 2 Mar 2009 12:18:01 +0200 (EET) Date: Mon, 2 Mar 2009 12:18:01 +0200 (EET) From: Mario Pavlov To: freebsd-current@freebsd.org, freebsd-amd64@freebsd.org Message-ID: <875050024.51828.1235989081194.JavaMail.apache@mail53.abv.bg> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1251" Content-Transfer-Encoding: 8bit X-Priority: 3 X-Mailer: AbvMail 1.0 X-Originating-IP: 78.128.21.208 Cc: dev@lists.pcbsd.org, kris@pcbsd.com Subject: Re: Re: [Fw: Re: [PC-BSD Dev] vmap()-like kernel interface ] - call for review X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Mar 2009 10:18:04 -0000 >On Fri, Feb 13, 2009 at 1:04 PM, Mario Pavlov wrote: >> Hi, >> please find the attached e-mail >> >> regards >> mgp >> >> P.S. thanks, PC-BSD team > > I'm not a kernel dev, but I noted that pmap_unmapcontig doesn't >take into consideration when va is NULL; I know it's bad driver >programming if uncontig is implicitly called with NULL, but there >should be some error handling or something here (a NULL deref will >occur in pmap_qremove, which will cause a panic). >Thanks, >-Garrett Hi, looks like most people just ignored this email. I am sure you all are very busy and you don't have time for everything but please try to find some time and review this work. People made an effort ... don't just throw it away. You know, many people long for 64bit driver. here's the attachment: http://lists.freebsd.org/pipermail/freebsd-amd64/attachments/20090213/567e04b7/PC-BSDDevvmap-likekernelinterface.eml thank you regards, mgp