From owner-svn-src-all@FreeBSD.ORG Mon Sep 29 18:39:32 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A7D99EFB; Mon, 29 Sep 2014 18:39:32 +0000 (UTC) Received: from smtp.fgznet.ch (mail.fgznet.ch [81.92.96.47]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 416CD2AE; Mon, 29 Sep 2014 18:39:31 +0000 (UTC) Received: from [192.168.225.11] (dhclient-91-190-14-19.flashcable.ch [91.190.14.19]) by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id s8TIVaK4098317; Mon, 29 Sep 2014 20:31:39 +0200 (CEST) (envelope-from andreast@FreeBSD.org) Message-ID: <5429A58E.2030508@FreeBSD.org> Date: Mon, 29 Sep 2014 20:31:42 +0200 From: Andreas Tobler User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Andrew Turner , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r272209 - in head/sys/arm: arm include References: <201409270957.s8R9vYrw056987@svn.freebsd.org> In-Reply-To: <201409270957.s8R9vYrw056987@svn.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.64 on 81.92.96.47 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Sep 2014 18:39:32 -0000 Hi Andrew, On 27.09.14 11:57, Andrew Turner wrote: > Author: andrew > Date: Sat Sep 27 09:57:34 2014 > New Revision: 272209 > URL: http://svnweb.freebsd.org/changeset/base/272209 > > Log: > Add machine/sysreg.h to simplify accessing the system control coprocessor > registers and use it in the ARMv7 CPU functions. > > The sysreg.h file has been checked by hand, however it may contain errors > with the comments on when a register was first introduced. The ARMv7 cpu > functions have been checked by compiling both the previous and this version > and comparing the md5 of the object files. > > Submitted by: Svatopluk Kraus > Submitted by: Michal Meloun > Reviewed by: ian, rpaulo > Differential Revision: https://reviews.freebsd.org/D795 > > Added: > head/sys/arm/include/sysreg.h (contents, props changed) This one breaks kernel build with gcc-4.2.1. __ARM_ARCH not defined. On gcc-4.2.1 there is no __ARM_ARCH builtin. Later gcc do have it. The include below fixes the build. Andreas Index: sys/arm/arm/cpufunc_asm_armv7.S =================================================================== --- sys/arm/arm/cpufunc_asm_armv7.S (revision 272282) +++ sys/arm/arm/cpufunc_asm_armv7.S (working copy) @@ -33,6 +33,7 @@ #include __FBSDID("$FreeBSD$"); +#include #include .cpu cortex-a8