From owner-freebsd-arch@FreeBSD.ORG  Fri Oct 29 17:42:36 2010
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 73E5E106566C
	for <arch@freebsd.org>; Fri, 29 Oct 2010 17:42:36 +0000 (UTC)
	(envelope-from gnn@neville-neil.com)
Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176])
	by mx1.freebsd.org (Postfix) with ESMTP id 4CA218FC17
	for <arch@freebsd.org>; Fri, 29 Oct 2010 17:42:36 +0000 (UTC)
Mime-Version: 1.0 (Apple Message framework v1081)
Content-Type: text/plain; charset=us-ascii
From: George Neville-Neil <gnn@neville-neil.com>
In-Reply-To: <AANLkTinO-vSUYLvg9R=OiZ-aYgZkFUNcAzfYf7vTBjNE@mail.gmail.com>
Date: Fri, 29 Oct 2010 13:42:33 -0400
Content-Transfer-Encoding: 7bit
Message-Id: <B96F636A-C2A3-43F9-8F4C-93889FB49C53@neville-neil.com>
References: <D92A9067-7305-42B6-8D15-D0A49A0542A4@neville-neil.com>
	<AANLkTinO-vSUYLvg9R=OiZ-aYgZkFUNcAzfYf7vTBjNE@mail.gmail.com>
To: Garrett Cooper <gcooper@freebsd.org>
X-Mailer: Apple Mail (2.1081)
X-AntiAbuse: This header was added to track abuse,
	please include it with any abuse report
X-AntiAbuse: Primary Hostname - vps.hungerhost.com
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - neville-neil.com
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Cc: arch@freebsd.org
Subject: Re: RFC: ARP Packet Queues
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Oct 2010 17:42:36 -0000


On Oct 29, 2010, at 13:19 , Garrett Cooper wrote:

>    1. This needs a tab after the #define for the macro:
> 
> +#define V_arp_maxhold		VNET(arp_maxhold)
> 

OK.

>    2. Is the naming convention for these sysctls always
> net.link.ether imply arp, or is it another naming convention?

I'm not quite sure what you're asking?

ARP maps from inet to ether so net.link.ether.inet is where these are.

Are you thinking about Neighbor Discovery and other such ARP like protocols
for other, higher layer, protocols?

>    3. Is there a reason why packets_dropped is a signed quantity,
> i.e. int, not size_t, etc?

I should fix that.

>    The rest looks ok, but I could be missing some context, or a
> subtlety of some kind. I'll give this a shot on my new router box this
> weekend because it looks interesting.

Thanks.

Be sure so increase maxtries as well as maxhold otherwise you'll be limited
in how many packets you can hold.

Best,
George