From owner-freebsd-current Sun Jun 16 6: 0:52 2002 Delivered-To: freebsd-current@freebsd.org Received: from gatesrv.RZ.UniBw-Muenchen.de (gatesrv.RZ.UniBW-Muenchen.de [137.193.11.27]) by hub.freebsd.org (Postfix) with ESMTP id 2617637B406; Sun, 16 Jun 2002 06:00:40 -0700 (PDT) Received: from nemesis.informatik.unibw-muenchen.de (nemesis.Informatik.UniBw-Muenchen.de [137.193.60.30]) by gatesrv.RZ.UniBw-Muenchen.de (8.11.2/8.11.2) with ESMTP id g5GCUUg19490; Sun, 16 Jun 2002 14:30:30 +0200 (MEST) Received: from localhost (localhost.informatik.unibw-muenchen.de [127.0.0.1]) by nemesis.informatik.unibw-muenchen.de (Postfix) with ESMTP id 3A9B95A548; Sun, 16 Jun 2002 14:30:30 +0200 (CEST) Received: by nemesis.informatik.unibw-muenchen.de (Postfix, from userid 1001) id 6E1AD5A546; Sun, 16 Jun 2002 14:30:29 +0200 (CEST) Date: Sun, 16 Jun 2002 14:30:29 +0200 From: Oliver Braun To: Kris Kennaway Cc: ijliao@freebsd.org, ports@freebsd.org, current@freebsd.org Subject: Re: rsync 5.x breakage Message-ID: <20020616123029.GA12998@informatik.unibw-muenchen.de> Mail-Followup-To: Oliver Braun , Kris Kennaway , ijliao@FreeBSD.org, ports@freebsd.org, current@freebsd.org References: <20020616040000.A16402@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020616040000.A16402@xor.obsecurity.org> User-Agent: Mutt/1.4i Organization: University of the Federal Armed Forces Munich, Germany X-Mailer: Mutt http://www.mutt.org/ X-OS: FreeBSD 4.6-PRERELEASE i386 http://www.freebsd.org/ X-Newsreader: SLRN http://www.slrn.org/ X-Uptime: 45 days X-URL: http://ist.unibw-muenchen.de/People/obraun X-Accept-Language: de en X-Location: Europe, Germany, Munich X-Editor: Vim-601 http://www.vim.org/ X-Virus-Scanned: by AMaViS snapshot-20020300 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG [CC ports@ and current@] * Kris Kennaway [2002-06-16 13:02]: > Looks like the ${REINPLACE_CMD} patch didn't work: > http://bento.freebsd.org/errorlogs/5-latest/rsync-2.5.5_1.log Fixed in PR ports/39365. But I am not very happy with that fix. The problem is that sed(1) on -current fails with "sed -i.bak file", if file.bak already exists, but perl does not. Since net/rsync/Makefile uses 3 ${REINPLACE_CMD}s on one file (rsync.h), I have removed the backup file with ${RM} file.bak between the calls. ==> ${REINPLACE_CMD} has different semantics on -current and -stable Maintainer only using -stable won't be able to get that error and fix it _before_ submitting. The extension bak has to be hardcoded in the Makefile. This is not very sexy, and after a change of ${REINPLACE_CMD} to something like sed -i.orig this will fail again. So, what about changing sed(1) on -current to unify semantics of ${REINPLACE_CMD}? Regards, Olli -- IST & IIS _ INF _ UniBwM ___________ http://ist.unibw-muenchen.de/People/obraun/ Tele-Consulting GmbH _______________ http://www.tele-consulting.com/ ___ obraun@ FreeBSD: The Power To Serve ________ http://www.freebsd.org/ ___________________ GnuPG: 0xEF25B1BA Fingerprint: 6A3B 042A 732E 17E4 B6E7 3EAF C0B1 6B7D EF25 B1BA To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message