From owner-cvs-all@FreeBSD.ORG Fri Dec 17 23:02:29 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27F8816A4CE; Fri, 17 Dec 2004 23:02:29 +0000 (GMT) Received: from connectmail.carleton.ca (connectmail.carleton.ca [134.117.2.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id B643243D49; Fri, 17 Dec 2004 23:02:28 +0000 (GMT) (envelope-from adamw@magnesium.net) Received: from [192.168.1.105] ([134.117.145.25]) by connectmail.carleton.ca (iPlanet Messaging Server 5.2 HotFix 1.21 (built Sep 8 2003)) with ESMTPSA id <0I8W004HX2O4VI@connectmail.carleton.ca>; Fri, 17 Dec 2004 18:02:29 -0500 (EST) Date: Fri, 17 Dec 2004 18:04:19 -0500 From: Adam Weinberger In-reply-to: <20041217224158.GA41450@xor.obsecurity.org> To: Kris Kennaway Message-id: <41C365F3.3090805@magnesium.net> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-Accept-Language: en-us, en User-Agent: Mozilla Thunderbird 1.0 (X11/20041212) References: <200412161851.iBGIpEeq058112@repoman.freebsd.org> <1103275349.98746.10.camel@pav.hide.vol.cz> <20041217141852.GJ79222@elvis.mu.org> <1103294201.98746.33.camel@pav.hide.vol.cz> <41C359C8.6090708@magnesium.net> <20041217222734.GN79222@elvis.mu.org> <41C35FD8.4090604@magnesium.net> <20041217224158.GA41450@xor.obsecurity.org> cc: kris@FreeBSD.org cc: Alfred Perlstein cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org cc: pav@FreeBSD.org cc: cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/irc/insub pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2004 23:02:29 -0000 Kris Kennaway wrote: > On Fri, Dec 17, 2004 at 05:38:16PM -0500, Adam Weinberger wrote: > >>Alfred Perlstein wrote: >> >>>* Adam Weinberger [041217 14:10] wrote: >>> >>> >>>>Cowsay needs to be part of the RUN_DEPENDS anyway. Otherwise, you have a >>>>bunch of cow files around with nothing that can use them. Besides, >>>>cowsay isn't actually part of the build, anyway. >>>> >>>>Furthermore, the @unexec rm %D/share/cows 2>/dev/null|| true should be >>>>added to cowsay's pkg-plist, not insub's. >>> >>> >>>Shall I do this? >>> >> >>I think so, yes. But cowsay belongs to Kris, and you should get approval >>from him (*poke, poke, you're Cc:'ed*). > > > If insub gains a dependency on cowsay (as it should), then nothing > needs to be done to cowsay, because insub will be pkg_deleted before > cowsay, and the share/cows directory will be empty by the time cowsay > tries to remove it. > > Kris Right, but it means that every cowsay upgrade will barf error messages. Which I thought is what the 2>/dev/null||true thing was there for. # Adam -- Adam Weinberger adamw@magnesium.net || adamw@FreeBSD.org adamw@vectors.cx || adamw@gnome.org http://www.vectors.cx