From owner-cvs-all Mon Aug 27 7:46:35 2001 Delivered-To: cvs-all@freebsd.org Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5]) by hub.freebsd.org (Postfix) with ESMTP id 0CE6137B405; Mon, 27 Aug 2001 07:46:21 -0700 (PDT) (envelope-from max@vega.com) Received: from vega.vega.com (root@dialup9-8.iptelecom.net.ua [212.9.228.8]) by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id RAA76807; Mon, 27 Aug 2001 17:46:13 +0300 (EEST) (envelope-from max@vega.com) Received: (from max@localhost) by vega.vega.com (8.11.4/8.11.3) id f7REkBL49390; Mon, 27 Aug 2001 17:46:11 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) From: Maxim Sobolev Message-Id: <200108271446.f7REkBL49390@vega.vega.com> Subject: Re: cvs commit: src/sys/dev/md md.c To: jhb@FreeBSD.ORG (John Baldwin) Date: Mon, 27 Aug 2001 17:45:11 +0300 (EEST) Cc: dima@unixfreak.org (Dima Dorfman), cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, sobomax@FreeBSD.ORG (Maxim Sobolev) In-Reply-To: from "John Baldwin" at Aug 27, 2001 07:14:13 AM X-Mailer: ELM [version 2.5 PL5] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > > On 27-Aug-01 Dima Dorfman wrote: > > Maxim Sobolev wrote: > >> sobomax 2001/08/27 06:25:48 PDT > >> > >> Modified files: > >> sys/dev/md md.c > >> Log: > >> - On module unload try to detach all configured disks and let unload > >> proceed > >> if all disks were detached sucessfully; > > > > I'm not sure this is wise. More likely than not, trying to unload md > > while there are still disks attached is a mistake on the user's part, > > especially considering that most people aren't going to be loading and > > unloading it on a regular basis. I understand why this may be useful > > for a developer working on md, but it seems counter-intuitive from a > > regular user's perspective. > > Yeah, I'd rather get an error (You're still using this stupid! *bonk*) like > EBUSY or some such rather than have it do magical things for me behind my back. Folks, have you tried to look into patches in question before commenting on them (no pun intended)? As I said the driver will try to detach *idle* disks only (i.e. configured but not opened), so they aren't really "in use". It is something like ejecting unmounted cd disk - it would be PITA if instead of just pushing the small button at its front panel you would be required to do some black magick to let system know that you are going to remove the physical media from the device. Perhaps I'm missing something, but I can't think of a single case when this feature can be harmful or even inconvenient. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message