From owner-svn-src-head@freebsd.org Fri Nov 30 19:58:02 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8C34C114E4E1; Fri, 30 Nov 2018 19:58:02 +0000 (UTC) (envelope-from arybchik@FreeBSD.org) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [84.52.114.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1B9CA732EF; Fri, 30 Nov 2018 19:58:02 +0000 (UTC) (envelope-from arybchik@FreeBSD.org) Received: from [192.168.1.192] (unknown [188.242.181.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E0F0E7F4F3; Fri, 30 Nov 2018 22:58:00 +0300 (MSK) Subject: Re: svn commit: r341327 - head/sys/dev/sfxge To: Brooks Davis Cc: John Baldwin , gnn@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, philip@FreeBSD.org References: <201811300711.wAU7B5R6084752@repo.freebsd.org> <7545b110-4930-d49f-f99f-7ec17db7e7a7@oktetlabs.ru> <20181130185418.GA4183@spindle.one-eyed-alien.net> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Fri, 30 Nov 2018 22:57:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181130185418.GA4183@spindle.one-eyed-alien.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: 1B9CA732EF X-Spamd-Result: default: False [0.43 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-0.22)[-0.219,0]; NEURAL_SPAM_SHORT(0.53)[0.533,0]; NEURAL_SPAM_LONG(0.11)[0.113,0]; ASN(0.00)[asn:25408, ipnet:84.52.64.0/18, country:RU] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2018 19:58:02 -0000 On 30.11.2018 21:54, Brooks Davis wrote: > On Fri, Nov 30, 2018 at 09:15:39PM +0300, Andrew Rybchenko wrote: >> On 30.11.2018 20:30, John Baldwin wrote: >>> On 11/29/18 11:11 PM, Andrew Rybchenko wrote: >>>> Author: arybchik >>>> Date: Fri Nov 30 07:11:05 2018 >>>> New Revision: 341327 >>>> URL: https://svnweb.freebsd.org/changeset/base/341327 >>>> >>>> Log: >>>> sfxge(4): rollback last seen VLAN TCI if Tx packet is dropped >>>> >>>> Early processing of a packet on transmit may change last seen >>>> VLAN TCI in the queue context. If such a packet is eventually >>>> dropped, last seen VLAN TCI must be set to its previous value. >>>> >>>> Submitted by: Ivan Malov >>>> Sponsored by: Solarflare Communications, Inc. >>>> MFC after: 1 week >>>> Differential Revision: https://reviews.freebsd.org/D18288 >>> Just as a general comment. There's no point in creating a review in >>> phabricator if you aren't going to get any actual review feedback via >>> the tool. That just adds noise. (I've spotchecked a few of the recent >>> sfxge commits and they all seem to create a review that then gets committed >>> a few hours later without any feedback, etc.) >> All these changesets is the result of development in Solarflare. >> All these changesets were reviewed internally and in fact many >> have later fixes which are simply squashed in. >> >> We have discussed it with George (gnn@) some time ago and >> he asked to submit reviews anyway and wait at least a day or >> two before commit. Yes in this particular case these 2 hundreds >> of patches is the result of 2 years of development. So, I'd >> waited some time and started to commit in blocks. >> >> This time I've not included np@ and bz@ in reviewers since I've >> not got reviewed before and it would be too much spam. >> >> We have discussed it with Philip (philip@) shortly. As I understand >> he has no time now to review it. >> >> Basically I'm ready to follow any sensible policy. I don't think it >> makes to wait forever. If there are any volunteers I'll be happy >> to include more people in reviewers. > You can't just throw things in phab and hope someone reviews them. If > you want then to be reviewed you need to work to have the reviewed. > That's true regardless of technology. > > In this case, it seems pretty clear they have been reviewed within > Solarflare so I don't think they really need to be reviewed within > FreeBSD processes before they land so long as they are well tested and > don't break the build. It makes sense. As I understand the argument from George was just give it a chance to be reviewed within FreeBSD process. Andrew.