From owner-freebsd-fs@freebsd.org Fri May 27 14:10:23 2016 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B5907B4BF41 for ; Fri, 27 May 2016 14:10:23 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3667A1FCD for ; Fri, 27 May 2016 14:10:23 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u4REAHlK091530 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 27 May 2016 17:10:17 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u4REAHlK091530 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u4REAGED091527; Fri, 27 May 2016 17:10:16 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 27 May 2016 17:10:16 +0300 From: Konstantin Belousov To: Yamagi Burmeister Cc: freebsd-fs@freebsd.org Subject: Re: LOR between allproc <-> ufs Message-ID: <20160527141016.GL38613@kib.kiev.ua> References: <20160526160902.bbe4c36ad340f11f69f7ba08@yamagi.org> <20160526155844.GH38613@kib.kiev.ua> <20160527153705.ee502c0a528cedd29c65b0ca@yamagi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160527153705.ee502c0a528cedd29c65b0ca@yamagi.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2016 14:10:23 -0000 On Fri, May 27, 2016 at 03:37:05PM +0200, Yamagi Burmeister wrote: > On Thu, 26 May 2016 18:58:44 +0300 > Konstantin Belousov wrote: > > > Completely untested patch is below. I do not think that this LOR > > can be reproduced at will. E.g. you need to record the order > > in witness by unmounting some filesystem mounted on a directory > > on UFS mount. Then, the chances must be that it was the last > > reference on the vmspace, or that there were deferred vnode entry. > > With this patch the system panics as soon there's some load on the > filesystem. Maybe only when several processes accessing the same > mountpoint, but I'm not sure. For example 'make -j24 buildkernel' > crashes the system nearly instantly. > at /usr/src/sys/kern/kern_shutdown.c:777 > #11 0xffffffff809b5aeb in witness_warn (flags=, lock=, > fmt=) at /usr/src/sys/kern/subr_witness.c:1757 > #12 0xffffffff809aa0a8 in userret (td=0xfffff800264c6960, frame=) > at /usr/src/sys/kern/subr_trap.c:157 > #13 0xffffffff80d78151 in amd64_syscall (td=0xfffff800264c6960, traced=) > at subr_syscall.c:185 This is an assert about some lock leak. Most useful is verbatim panic message with all surrounding kernel printouts. I do not even need the backtrace.