From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Aug 16 19:20:05 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 42BC4106568D for ; Sun, 16 Aug 2009 19:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 206158FC4B for ; Sun, 16 Aug 2009 19:20:05 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n7GJK4w7098036 for ; Sun, 16 Aug 2009 19:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n7GJK4T6098035; Sun, 16 Aug 2009 19:20:04 GMT (envelope-from gnats) Resent-Date: Sun, 16 Aug 2009 19:20:04 GMT Resent-Message-Id: <200908161920.n7GJK4T6098035@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Piotr Smyrak Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 87525106568C for ; Sun, 16 Aug 2009 19:19:05 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 5DA348FC16 for ; Sun, 16 Aug 2009 19:19:05 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7GJJ4CY051759 for ; Sun, 16 Aug 2009 19:19:04 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n7GJJ4ER051758; Sun, 16 Aug 2009 19:19:04 GMT (envelope-from nobody) Message-Id: <200908161919.n7GJJ4ER051758@www.freebsd.org> Date: Sun, 16 Aug 2009 19:19:04 GMT From: Piotr Smyrak To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/137855: early identify port conflicts X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2009 19:20:05 -0000 >Number: 137855 >Category: ports >Synopsis: early identify port conflicts >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Aug 16 19:20:04 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Piotr Smyrak >Release: 7.2-STABLE >Organization: >Environment: FreeBSD dsk.smyrak.com 7.2-STABLE FreeBSD 7.2-STABLE #0: Thu Jul 30 20:23:13 CEST 2009 root@dsk.smyrak.com:/usr/obj/usr/src/sys/SMYRU i386 >Description: Currently the port build checks for existing conflicts very late after install-message target. Just imagine a situation where one has to download a big tarball, build it, and out of sudden, when everything is prepared, even dependences were installed, the port will refuse to cooperate due to a conflict. Fine if it can be safely resolved, but quite annoying, when the conflicting app is needed and cannot be removed. Moving check-conflicts target before check-depends into _SANITY_SEQ sounds quite logical and safe. See attached patch. >How-To-Repeat: >Fix: Apply the attached patch Patch attached with submission follows: --- bsd.port.mk.orig 2009-08-16 21:00:55.000000000 +0200 +++ bsd.port.mk 2009-08-16 21:06:45.000000000 +0200 @@ -4160,10 +4160,10 @@ .else _CHROOT_SEQ= .endif -_SANITY_SEQ= ${_CHROOT_SEQ} pre-everything check-makefile check-categories \ - check-makevars check-desktop-entries check-depends \ - check-deprecated check-vulnerable buildanyway-message \ - options-message +_SANITY_SEQ= ${_CHROOT_SEQ} pre-everything check-makefile \ + check-categories check-makevars check-desktop-entries \ + check-conflicts check-depends check-deprecated \ + check-vulnerable buildanyway-message options-message _FETCH_DEP= check-sanity _FETCH_SEQ= fetch-depends pre-fetch pre-fetch-script \ do-fetch post-fetch post-fetch-script @@ -4182,8 +4182,7 @@ _BUILD_SEQ= build-message pre-build pre-build-script do-build \ post-build post-build-script _INSTALL_DEP= build -_INSTALL_SEQ= install-message check-conflicts \ - run-depends lib-depends apply-slist pre-install \ +_INSTALL_SEQ= install-message run-depends lib-depends apply-slist pre-install \ pre-install-script generate-plist check-already-installed _INSTALL_SUSEQ= check-umask install-mtree pre-su-install \ pre-su-install-script do-install install-desktop-entries \ >Release-Note: >Audit-Trail: >Unformatted: