From owner-freebsd-bluetooth@FreeBSD.ORG Tue Oct 6 15:48:04 2009 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CF901065679 for ; Tue, 6 Oct 2009 15:48:04 +0000 (UTC) (envelope-from masoom.shaikh@gmail.com) Received: from mail-pz0-f185.google.com (mail-pz0-f185.google.com [209.85.222.185]) by mx1.freebsd.org (Postfix) with ESMTP id 5D3AD8FC14 for ; Tue, 6 Oct 2009 15:48:04 +0000 (UTC) Received: by pzk15 with SMTP id 15so3606329pzk.3 for ; Tue, 06 Oct 2009 08:48:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=Eg4ZAM5/B//wayCPJQFR2x2jZi7YwOsMzgwCdGEC48U=; b=I5zeuOd2JGihSdV0NL/F2yPhukDfStraBbomXlMbuyJQcaYbiir3S13sbLwNdcaa17 qADxaZjqhzfV+3WZKUsiaujFTluqulQ4qo/RxLjHZkMw+Hnqj9Xxmjxk3LVeZIXLLiFC jKTN+SBW0K9WI0GCiJ4ef6zrIr9ksKLgdeb4w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=uADqpCucKojUdZkdSYxNCx0SQa4pIdN0VabaoJulCfzH6g2bHsOmrTUBgfjyqVH2Qc ERmyIqB+qytzcUfMKnBq/SR9MX0Ufb4iZ7x6Yu9ZIvDeZnrQXtgKt0jj28/iarGN2DvO uM17lXxaxbEC0zuWR6tXH9jka93ighQpLVQUw= MIME-Version: 1.0 Received: by 10.115.100.14 with SMTP id c14mr2509015wam.219.1254844082992; Tue, 06 Oct 2009 08:48:02 -0700 (PDT) In-Reply-To: <1254763597.419838.805.nullmailer@galant.ukfsn.org> References: <1254763597.419838.805.nullmailer@galant.ukfsn.org> Date: Tue, 6 Oct 2009 15:48:02 +0000 Message-ID: From: Masoom Shaikh To: Iain Hibbert Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-bluetooth@freebsd.org Subject: Re: bluetooth.h, c++ include error X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2009 15:48:04 -0000 On Mon, Oct 5, 2009 at 5:26 PM, Iain Hibbert wrote: > On Mon, 5 Oct 2009, Masoom Shaikh wrote: > > > what i am requesting is just variable name change ;-) my tree is at > > revision 197571, thus the patch i am presenting is also generated > > against it reject this if you want patch against latest revision > > > > renamed second argument of bt_devfilter() from 'new' to 'dfnew'. df for > > device filter to maintain uniformity renamed third argument from 'old' > > to 'dfold'. > > style(9) mentions that for kernel include files exposed to userland > (technically, this is always in userland but perhaps the same rules apply) > the prototype tag arguments should be made safe, eg starting with a _ > perhaps for much this reason.. > > so, my suggestion would be to use _new and _old etc.. > > iain > > (or, just don't use them, they are not especially required :) > > > > > so this shall work i just renamed bt_devfilter() variable names, because it was the one which caused trouble will someone commit this ? Index: bluetooth.h =================================================================== --- bluetooth.h (revision 197804) +++ bluetooth.h (working copy) @@ -163,8 +163,8 @@ int bt_devsend (int s, uint16_t opcode, void *param, size_t plen); ssize_t bt_devrecv (int s, void *buf, size_t size, time_t to); int bt_devreq (int s, struct bt_devreq *r, time_t to); -int bt_devfilter(int s, struct bt_devfilter const *new, - struct bt_devfilter *old); +int bt_devfilter(int s, struct bt_devfilter const *_new, + struct bt_devfilter *_old); void bt_devfilter_pkt_set(struct bt_devfilter *filter, uint8_t type); void bt_devfilter_pkt_clr(struct bt_devfilter *filter, uint8_t type); int bt_devfilter_pkt_tst(struct bt_devfilter const *filter, uint8_t type);