From owner-svn-ports-all@FreeBSD.ORG  Sun Apr  6 23:49:51 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CB1F47C3;
 Sun,  6 Apr 2014 23:49:51 +0000 (UTC)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 by mx1.freebsd.org (Postfix) with ESMTP id A7942BF6;
 Sun,  6 Apr 2014 23:49:51 +0000 (UTC)
Received: from [192.168.0.132] (vie-188-118-253-065.dsl.sil.at
 [188.118.253.65])
 by ainaz.pair.com (Postfix) with ESMTPSA id 76B4F3F410;
 Sun,  6 Apr 2014 19:49:38 -0400 (EDT)
Date: Mon, 7 Apr 2014 01:49:59 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, 
 Muhammad Moinur Rahman <5u623l20@gmail.com>
Subject: Re: svn commit: r350329 - in head/devel/bisoncpp: . files
In-Reply-To: <201404060549.s365nYuf010306@svn.freebsd.org>
Message-ID: <alpine.LSU.2.11.1404070144430.5303@tuna.site>
References: <201404060549.s365nYuf010306@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Apr 2014 23:49:51 -0000

On Sun, 6 Apr 2014, Sunpoet Po-Chuan Hsieh wrote:
> Log:
>   - Update to 4.08.00
>   - Pass maintainership to submitter
>   - While I'm here, relax USE_GCC to yes
>   
>   Changes:	http://sourceforge.net/projects/bisoncpp/files/bisonc%2B%2B/4.08.00/README/view
>   		http://sourceforge.net/projects/bisoncpp/files/bisonc%2B%2B/4.07.00/README/view
>   		http://sourceforge.net/projects/bisoncpp/files/bisonc%2B%2B/4.06.00/README/view
>   PR:		188267
>   Submitted by:	Muhammad Moinur Rahman <5u623l20@gmail.com>

> Modified: head/devel/bisoncpp/Makefile
> ==============================================================================
> -USE_GCC=	4.7
> +USE_GCC=	yes

This change is not correct.

Check out the following lines later in this Makefile:

        @${REINPLACE_CMD} 's|"g++|"g++47|' \
                ${WRKSRC}/INSTALL.im \
                ${WRKSRC}/scanner/driver/build \
                ${WRKSRC}/parser/driver/build
        @${REINPLACE_CMD} 's|"gcc|"gcc47|' \
                ${WRKSRC}/icmake/special

This works by chance today since USE_GCC=yes defaults to GCC 4.7.

It will break for anyone installing (only) lang/gcc48 or when we
switch to GCC 4.8 as default.

Can you please fix this?  

Gerald

PS: If ${CC} is set at this point, that would be the best option
instead of hard-coding things.