From owner-freebsd-doc@FreeBSD.ORG Mon Feb 21 12:20:08 2005 Return-Path: Delivered-To: freebsd-doc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE84D16A4E3 for ; Mon, 21 Feb 2005 12:20:08 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F93343D79 for ; Mon, 21 Feb 2005 12:20:08 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j1LCK8kC048930 for ; Mon, 21 Feb 2005 12:20:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j1LCK84h048929; Mon, 21 Feb 2005 12:20:08 GMT (envelope-from gnats) Date: Mon, 21 Feb 2005 12:20:08 GMT Message-Id: <200502211220.j1LCK84h048929@freefall.freebsd.org> To: freebsd-doc@FreeBSD.org From: "Simon L. Nielsen" Subject: Re: docs/77851: articles/committers-guide: change Approved -> Reviewed X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: "Simon L. Nielsen" List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2005 12:20:08 -0000 The following reply was made to PR docs/77851; it has been noted by GNATS. From: "Simon L. Nielsen" To: Florent Thoumie Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: docs/77851: articles/committers-guide: change Approved -> Reviewed Date: Mon, 21 Feb 2005 13:19:23 +0100 --UFHRwCdBEJvubb2X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2005.02.21 12:59:15 +0100, Florent Thoumie wrote: > These are two different statements of the Committer's Guide. I think the > second one is erroneous. It isn't, it's different topics. > "Approved by" is only acceptable from non-mentored src committers -- ment= ored > committers can provide a "Reviewed by" but not an "Approved by". This is from the "2.1 Policy for doc/ committer activity in src/" section, ie. only for doc committers (if they are mentored or not) and only wrt. commtting to src/. > Until your mentor decides (and announces with a forced commit to access) = that > you have learned the ropes and are ready to commit on your own, you shoul= d not > commit anything without first getting your mentor's review and approval, = and > you should document that approval with an Approved by: line in the commit > message. This is general for all committers being mentored and is correct (though not entirely at least wrt. to doc/ people but that's another matter). --=20 Simon L. Nielsen --UFHRwCdBEJvubb2X Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCGdHLh9pcDSc1mlERAgvuAJwL7zeZRWgc3TdLxdvLDV734YIilACggth6 e9e27XmdwsDVoPTOPDh77tE= =vMZf -----END PGP SIGNATURE----- --UFHRwCdBEJvubb2X--