Date: Mon, 21 Feb 2005 12:20:08 GMT From: "Simon L. Nielsen" <simon@FreeBSD.org> To: freebsd-doc@FreeBSD.org Subject: Re: docs/77851: articles/committers-guide: change Approved -> Reviewed Message-ID: <200502211220.j1LCK84h048929@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR docs/77851; it has been noted by GNATS. From: "Simon L. Nielsen" <simon@FreeBSD.org> To: Florent Thoumie <flz@xbsd.org> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: docs/77851: articles/committers-guide: change Approved -> Reviewed Date: Mon, 21 Feb 2005 13:19:23 +0100 --UFHRwCdBEJvubb2X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2005.02.21 12:59:15 +0100, Florent Thoumie wrote: > These are two different statements of the Committer's Guide. I think the > second one is erroneous. It isn't, it's different topics. > "Approved by" is only acceptable from non-mentored src committers -- ment= ored > committers can provide a "Reviewed by" but not an "Approved by". This is from the "2.1 Policy for doc/ committer activity in src/" section, ie. only for doc committers (if they are mentored or not) and only wrt. commtting to src/. > Until your mentor decides (and announces with a forced commit to access) = that > you have learned the ropes and are ready to commit on your own, you shoul= d not > commit anything without first getting your mentor's review and approval, = and > you should document that approval with an Approved by: line in the commit > message. This is general for all committers being mentored and is correct (though not entirely at least wrt. to doc/ people but that's another matter). --=20 Simon L. Nielsen --UFHRwCdBEJvubb2X Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCGdHLh9pcDSc1mlERAgvuAJwL7zeZRWgc3TdLxdvLDV734YIilACggth6 e9e27XmdwsDVoPTOPDh77tE= =vMZf -----END PGP SIGNATURE----- --UFHRwCdBEJvubb2X--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502211220.j1LCK84h048929>