From owner-svn-src-all@freebsd.org Sat Aug 17 06:06:51 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 721ADBC706; Sat, 17 Aug 2019 06:06:51 +0000 (UTC) (envelope-from mckusick@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469V7v2SMgz424N; Sat, 17 Aug 2019 06:06:51 +0000 (UTC) (envelope-from mckusick@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1D0A5D62B; Sat, 17 Aug 2019 06:06:51 +0000 (UTC) (envelope-from mckusick@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x7H66oIe058488; Sat, 17 Aug 2019 06:06:50 GMT (envelope-from mckusick@FreeBSD.org) Received: (from mckusick@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x7H66o3P058487; Sat, 17 Aug 2019 06:06:50 GMT (envelope-from mckusick@FreeBSD.org) Message-Id: <201908170606.x7H66o3P058487@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mckusick set sender to mckusick@FreeBSD.org using -f From: Kirk McKusick Date: Sat, 17 Aug 2019 06:06:50 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r351164 - stable/12/sys/ufs/ffs X-SVN-Group: stable-12 X-SVN-Commit-Author: mckusick X-SVN-Commit-Paths: stable/12/sys/ufs/ffs X-SVN-Commit-Revision: 351164 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 06:06:51 -0000 Author: mckusick Date: Sat Aug 17 06:06:50 2019 New Revision: 351164 URL: https://svnweb.freebsd.org/changeset/base/351164 Log: MFC of 351002 Clarify how FS_METACKHASH flag is managed. Modified: stable/12/sys/ufs/ffs/fs.h Directory Properties: stable/12/ (props changed) Modified: stable/12/sys/ufs/ffs/fs.h ============================================================================== --- stable/12/sys/ufs/ffs/fs.h Sat Aug 17 03:09:03 2019 (r351163) +++ stable/12/sys/ufs/ffs/fs.h Sat Aug 17 06:06:50 2019 (r351164) @@ -408,22 +408,27 @@ CTASSERT(sizeof(struct fs) == 1376); * The FS_UNCLEAN flag is set by the kernel when the filesystem was * mounted with fs_clean set to zero. The FS_DOSOFTDEP flag indicates * that the filesystem should be managed by the soft updates code. - * Note that the FS_NEEDSFSCK flag is set and cleared only by the - * fsck utility. It is set when background fsck finds an unexpected + * Note that the FS_NEEDSFSCK flag is set and cleared by the fsck + * utility. It is set when background fsck finds an unexpected * inconsistency which requires a traditional foreground fsck to be * run. Such inconsistencies should only be found after an uncorrectable - * disk error. A foreground fsck will clear the FS_NEEDSFSCK flag when - * it has successfully cleaned up the filesystem. The kernel uses this + * disk error. The FS_NEEDSFSCK can also be set when a mounted filesystem + * discovers an internal inconsistency such as freeing a freed inode. + * A foreground fsck will clear the FS_NEEDSFSCK flag when it has + * successfully cleaned up the filesystem. The kernel uses this * flag to enforce that inconsistent filesystems be mounted read-only. - * The FS_INDEXDIRS flag when set indicates that the kernel maintains - * on-disk auxiliary indexes (such as B-trees) for speeding directory - * accesses. Kernels that do not support auxiliary indices clear the - * flag to indicate that the indices need to be rebuilt (by fsck) before - * they can be used. When a filesystem is mounted, any flags not - * included in FS_SUPPORTED are cleared. This lets newer features - * know that the filesystem has been run on an older version of the - * filesystem and thus that data structures associated with those - * features are out-of-date and need to be rebuilt. + * + * The FS_METACKHASH flag when set indicates that the kernel maintains + * one or more check hashes. The actual set of supported check hashes + * is stored in the fs_metackhash field. Kernels that do not support + * check hashes clear the FS_METACKHASH flag to indicate that the + * check hashes need to be rebuilt (by fsck) before they can be used. + * + * When a filesystem is mounted, any flags not included in FS_SUPPORTED + * are cleared. This lets newer features know that the filesystem has + * been run on an older version of the filesystem and thus that data + * structures associated with those features are out-of-date and need + * to be rebuilt. * * FS_ACLS indicates that POSIX.1e ACLs are administratively enabled * for the file system, so they should be loaded from extended attributes,