Date: Sun, 07 Apr 2024 15:13:40 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 277708] net/cloud-init: new release: 24.1.1 Message-ID: <bug-277708-7788-eFuq87hxeC@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-277708-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-277708-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277708 Joseph Mingrone <jrm@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrm@freebsd.org --- Comment #9 from Joseph Mingrone <jrm@freebsd.org> --- Thanks Mina. A few tweaks are required. For the net/cloud-init changes: 1. You need TABS (not spaces) after `=3D` in PATCH_SITES=3D and PATCHFILES+= =3D. 2. PATCH_SITES=3D and PATCHFILES+=3D should come before the MAINTAINER=3D g= roup.=20 portclippy from ports-mgmt/portfmt is a helpful linter for things like this. 3. The build fails because the two patches you submitted upstream are alrea= dy included in 24.1.4. So, in the end, we have to remove the PATCH_SITES=3D and PATCHFILES+=3D lin= es. net/cloud-init-devel looks good to me. For the commit logs, we should: 1. Include a reference to this PR 2. Use a TAB after 'Sponsored by:' 3. Include 'Approved by:' for the net/cloud-init update since someone else maintains the port. In this case, since two weeks have passed, we should u= se Approved by: andrey@bsdnir.info (maintainer, timeout). You can install the commit message template hook to make writing commit logs easier. See https://docs.freebsd.org/en/articles/committers-guide/#git-mini-primer-gett= ing-started. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-277708-7788-eFuq87hxeC>