From owner-svn-src-all@freebsd.org Fri Nov 13 23:19:32 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8233DA2EA9D for ; Fri, 13 Nov 2015 23:19:32 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 116121367 for ; Fri, 13 Nov 2015 23:19:32 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by wmww144 with SMTP id w144so50583577wmw.0 for ; Fri, 13 Nov 2015 15:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay_co_uk.20150623.gappssmtp.com; s=20150623; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=JJhZlcFH7zjO0ABOmbQ/eZeYMl127kgEki5LZm3bKmk=; b=GoVNyruMNMz4M2V3q4cnbg2F/mjecPd+WJcLOeDtJKV1/3SUqDFe7Adc9QzIzWq/rB UXwlqgV8yVSEXWBTIgax3Y3dTSMgldj5RnJ6MjoOc43IWgwd2W/rjjmc0ei4+GwM01yn YUenV8qdAG+oppOEQm0fE/za1DjbR8p1G1rnornnfH2Y0SqY3CCIDQpDHqiXuYVAHllj J9dzCxWr/nT1r8HUGt5Pe0GxWzRVLRyMndk3C+3EJq7JlTwIwMakyvGuiDyjCS76+jCY BwhOQPLXZz8yBAnW0QcSfSOFtfidcamFK/Ku/V6RMnsWy6jU02uyAMuNOjowsKJGwovJ RfEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=JJhZlcFH7zjO0ABOmbQ/eZeYMl127kgEki5LZm3bKmk=; b=ZTs9bXMfRzibR0ewWC55sT0FEGO94S18jzADNQIGcf/f2+GOXG+fP+wBDhRYZ44nOP 0pwknOkEUtrbujbgXrm0gKE601nEJAGTvvNOd44qrqGPHX07EjsRUilYeycclQzSMAKx i9FHFRUxTxFFUWkFnhpziUJ8L+Yi/AFckpDMcNwOQrRD2RJ2HgVByRJiLgZh8Rotj2Yc KbvHm0UdC0Sy4SuIUezrNL+IXarkm3lC39n+//uchtWvY9flCUMIvp32FR3xe2UV5tEP D01lG1dWKxh6EE6z8UIbxopip7oq7aFt/6QpurHawrNNigr26cZx64tFW2KfqX2gGf+y +L1Q== X-Gm-Message-State: ALoCoQlho3kIthwTqmACzXpQ5DQYyvDKofs3RVwISpQ0YZLSDtcmxIOOAz/aWKq12zsFYPCQ5VmM X-Received: by 10.194.185.42 with SMTP id ez10mr14382867wjc.82.1447456770084; Fri, 13 Nov 2015 15:19:30 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id gl9sm22012389wjb.10.2015.11.13.15.19.28 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 13 Nov 2015 15:19:29 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r290403 - head/sys/netinet To: Gleb Smirnoff References: <201511051723.tA5HN24j065530@repo.freebsd.org> <20151113214204.GA73031@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <5646700E.4010701@freebsd.org> Date: Fri, 13 Nov 2015 23:19:42 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151113214204.GA73031@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 23:19:32 -0000 On 13/11/2015 21:42, Gleb Smirnoff wrote: > Steven, > > On Thu, Nov 05, 2015 at 05:23:02PM +0000, Steven Hartland wrote: > S> Author: smh > S> Date: Thu Nov 5 17:23:02 2015 > S> New Revision: 290403 > S> URL: https://svnweb.freebsd.org/changeset/base/290403 > S> > S> Log: > S> Add MTU support to carp interfaces > S> > S> MFC after: 2 weeks > S> Sponsored by: Multiplay > > What is "carp interfaces"? I believe you are committing a patch to FreeBSD 9 > into FreeBSD 11, w/o doing any testing and w/o doing even light review of > surrounding code, which differes a lot from FreeBSD 9. > > Please back this out or correct me being wrong. > You're correct, this was something we've had hanging around from a long time, backed out by r290403. I should have both know that the CARP rework invalided it and also should have re-tested before committing it don't know what I was thinking that day, apologies and thanks for highlighting it. Regards Steve