From owner-svn-ports-all@FreeBSD.ORG Thu Mar 14 17:37:52 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 84FACDC for ; Thu, 14 Mar 2013 17:37:52 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-ve0-f176.google.com (mail-ve0-f176.google.com [209.85.128.176]) by mx1.freebsd.org (Postfix) with ESMTP id 45004EE7 for ; Thu, 14 Mar 2013 17:37:51 +0000 (UTC) Received: by mail-ve0-f176.google.com with SMTP id cz10so1920609veb.35 for ; Thu, 14 Mar 2013 10:37:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=0ql5DooV8NTG5UrVIAOOIMiHwNXTvCif1xWuVLKNFc0=; b=AfXNMAE2WapiiSk/NB5Hv9FdQd4cP3GKuwiX9gG6td4MotcPHNQzVxue8JEQLly0+r I3N/kjJQmc+qr/TeqgRe9HXLGHkNubt13vRQXVQnOCWiHHNna1OyJMz7l3HTissZlfl3 yIEhfhCZkQxo3922DelRq5IQcnJ9rnb9ZB2Jb6nCjjJtkjhqAhjEtqp8vVaD4vK4wKfc X4zt7SE/Nn0v4Vpw2e7luYyGJQj380vU0XyzeEXiNLTbunzvHNBF2YyjzROtCE0XpvqD 9FjhmMTsvVRKyMcKXPMEq3DB+q6fBw6IcaltYaCpBP5quLBjOHYMrJzwtn7MKrlSTJsa IACw== MIME-Version: 1.0 X-Received: by 10.52.175.66 with SMTP id by2mr2577251vdc.53.1363282671270; Thu, 14 Mar 2013 10:37:51 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.58.30.79 with HTTP; Thu, 14 Mar 2013 10:37:51 -0700 (PDT) In-Reply-To: <20130314165712.GA8275@FreeBSD.org> References: <201303132159.r2DLx1QL092713@svn.freebsd.org> <20130314070455.GA42406@hatter> <20130314075330.GA94901@FreeBSD.org> <201303132359.22984.beech@freebsd.org> <20130314081701.GA6014@FreeBSD.org> <20130314165712.GA8275@FreeBSD.org> Date: Thu, 14 Mar 2013 10:37:51 -0700 X-Google-Sender-Auth: 2TqlBuKaO304s-LZ5b9OOafrv38 Message-ID: Subject: Re: svn commit: r314117 - head/games/kye From: Jason Helfman To: Alexey Dokuchaev X-Gm-Message-State: ALoCoQllhqoPSvSNHQJyI6f6MTD5A2glLZfKfkjrcHyJx/jsvVKc/+dnzZTRhRzSoIQuruydOyxG Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Beech Rintoul , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2013 17:37:52 -0000 On Thu, Mar 14, 2013 at 9:57 AM, Alexey Dokuchaev wrote: > On Thu, Mar 14, 2013 at 08:30:06AM -0700, Jason Helfman wrote: > > PORTDOCS make variable assignment is different then a PLIST_SUB. It also > > depends how it is used in the Makefile. In this instance, they are both > > used correctly. > > PORTDOCS were introduced precisely to be able to off-load pkg-plist for > simple cases, like this one. I really do not understand what point are > you trying to make here Jason, sorry. For me it looks that ${TMPPLIST} > will now contain two copies of the docs, which upsets package deinstall. > > If you still believe you're being right here, can you please explain: > > - Why there are two instances of docs in .PLIST.mktmp, per simple grep? > - Why would anyone what to record docs twice (in PORTDOCS and pkg-plist)? > - Why do I see this: > > $ make deinstall > ===> Switching to root credentials for 'deinstall' target > Password: > ===> Deinstalling for games/kye > ===> Deinstalling py27-kye-1.0_3 > pkg_delete: file '/tmp/j/share/doc/kye/NEWS' doesn't exist > pkg_delete: file '/tmp/j/share/doc/kye/README' doesn't exist > pkg_delete: file '/tmp/j/share/doc/kye' doesn't exist > pkg_delete: unable to completely remove directory '/tmp/j/share/doc/kye' > pkg_delete: couldn't entirely delete package `py27-kye-1.0_3' > (perhaps the packing list is incorrectly specified?) > ===> Returning to user credentials > > Do you still disagree that PORTDOCS lines should be removed from pkg-plist > in favor of PORTDOCS set in the Makefile? > > ./danfe > > I completely agree with you, however since PLIST_SUB isn't doing anything in the Makefile, nor the pkg-plist, I really don't see the use for it. For some reason, the maintainer is using it, and I trusted that it had built fine per committer. I, myself, normally prefer: PORTDOCS= * And have nothing related to %%PORTDOCS%% in plist. -jgh