From owner-freebsd-rc@FreeBSD.ORG  Mon Aug 10 18:44:30 2009
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CA06F106566C;
	Mon, 10 Aug 2009 18:44:30 +0000 (UTC) (envelope-from ady@ady.ro)
Received: from mail-ew0-f206.google.com (mail-ew0-f206.google.com
	[209.85.219.206])
	by mx1.freebsd.org (Postfix) with ESMTP id F3AEB8FC1E;
	Mon, 10 Aug 2009 18:44:29 +0000 (UTC)
Received: by ewy2 with SMTP id 2so3203610ewy.43
	for <multiple recipients>; Mon, 10 Aug 2009 11:44:28 -0700 (PDT)
MIME-Version: 1.0
Sender: ady@ady.ro
Received: by 10.210.10.8 with SMTP id 8mr5250984ebj.82.1249928014495; Mon, 10 
	Aug 2009 11:13:34 -0700 (PDT)
In-Reply-To: <alpine.BSF.2.00.0908092234390.50801@qbhto.arg>
References: <4A7B2792.4090803@delphij.net> <4A7B487B.8060303@FreeBSD.org>
	<4A7F948A.2040602@delphij.net> <4A7F9EC6.9090605@FreeBSD.org>
	<4A7FAA42.4030607@delphij.net>
	<alpine.BSF.2.00.0908092234390.50801@qbhto.arg>
Date: Mon, 10 Aug 2009 20:13:34 +0200
X-Google-Sender-Auth: 638977484a586987
Message-ID: <78cb3d3f0908101113s412021adk8956dd083a8fed72@mail.gmail.com>
From: Adrian Penisoara <ady@freebsd.ady.ro>
To: Doug Barton <dougb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: freebsd-rc@freebsd.org, d@delphij.net
Subject: Re: [RFC] script for binding ARP <-> IP pairs
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Aug 2009 18:44:31 -0000

Hi,

On Mon, Aug 10, 2009 at 7:34 AM, Doug Barton <dougb@freebsd.org> wrote:

> On Sun, 9 Aug 2009, Xin LI wrote:
>
>  Hi, Doug,
>>
>> Doug Barton wrote:
>>
>>> Xin LI wrote:
>>>
>>>  Thanks for your comments, I have put together the revised patch, along
>>>> with rc.conf.5 and defaults/rc.conf changes.
>>>>
>>>
>>> Glad to help. This looks fine except that you need an entry for
>>> static_arp_enable in defaults rc.conf and rc.conf.5.
>>>
>>
>> This script does not require the enable knob.  If the static_arp_pairs
>> is not empty then the script would add the entries, otherwise it will
>> not do that.  Do you think we need an "enable" knob for it?  I can add
>> it but I don't feel strongly for the idea, since it would make a
>> redundant entry to represent the same semantic.
>>
>
> I missed the fact that you're not using rcvar. I'm sort of ambivalent about
> that, as I prefer things to be


I guess you could compare this to the cloned_interfaces rcvar...


> consistent, but I'm not actively opposed to it. If no one else has an
> objection go ahead and send it to -net.
>

Just a bit of QC/improvement:

Index: etc/rc.d/static_arp
===================================================================
-               echo -n 'Binding static ARP pair:'
+               echo -n 'Binding static ARP pair(s):'

-                       arp_args=`echo ${arp_args} | sed -e
s,..:..:..:..:..:..,,g`
+                       arp_args=`echo ${arp_args} | awk '{ print $1 }'`


Index: share/man/man5/rc.conf.5
===================================================================
-Set to the list of static ARP paris that are to be added at system
+Set to the list of static ARP pairs that are to be added at system


Regards,
Adrian Penisoara
EnterpriseBSD