From owner-freebsd-bugs  Sat Jun 14 06:20:04 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id GAA22795
          for bugs-outgoing; Sat, 14 Jun 1997 06:20:04 -0700 (PDT)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id GAA22763;
          Sat, 14 Jun 1997 06:20:02 -0700 (PDT)
Date: Sat, 14 Jun 1997 06:20:02 -0700 (PDT)
Message-Id: <199706141320.GAA22763@hub.freebsd.org>
To: freebsd-bugs
Cc: 
From: Tim Vanderhoek <tim@X2296>
Subject: Re: bin/3451: vasprintf() doesn't work.
Reply-To: Tim Vanderhoek <tim@X2296>
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

The following reply was made to PR bin/3451; it has been noted by GNATS.

From: Tim Vanderhoek <tim@X2296>
To: hoek@hwcn.org
Cc: Bruce Evans <bde@zeta.org.au>, ac199@hwcn.org,
        freebsd-bugs@hub.freebsd.org, freebsd-gnats-submit@freebsd.org
Subject: Re: bin/3451: vasprintf() doesn't work.
Date: Sat, 14 Jun 1997 09:14:29 -0400 (EDT)

 On Sat, 14 Jun 1997, Tim Vanderhoek wrote:
 
 > On Sat, 14 Jun 1997, Bruce Evans wrote:
 > 
 > > >   	*str = realloc(h.base, (size_t)(h.size - h.left + 1));
 > > >   	if (*str == NULL)	/* failed to realloc it to actual size */
 > > > ! 		return (-1);
 > > > ! 	(*str)[h.size - h.left] = '\0';
 > > >   	return (ret);
 > 
 > Which, of course, points us to yet another error in the original
 > vasprintf.c...  :)  The test to see if str is NULL is
 > *str == NULL....
 
 No, wait...  That should be *str == NULL...  Just ignore that
 patch, and just put the free(h.base) in there...
 
 Sheesh...  I should really look this stuff over before I send
 it...  :-(
 
 > ! 	if (str == NULL) {	/* failed to realloc it to actual size */
   !	if (*str == NULL) {	/* failed to realloc it to actual size */
 ^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 corrected.  again.
 
 --
 tIM...HOEk
 optimization: The theory that making your code incomprehensible by using
               only one-letter variable names will make it run faster.