From owner-freebsd-security@FreeBSD.ORG  Sat Jun 16 18:14:14 2012
Return-Path: <owner-freebsd-security@FreeBSD.ORG>
Delivered-To: freebsd-security@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1239E106566B
	for <freebsd-security@freebsd.org>;
	Sat, 16 Jun 2012 18:14:14 +0000 (UTC) (envelope-from bz@freebsd.org)
Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90])
	by mx1.freebsd.org (Postfix) with ESMTP id B5A008FC1B
	for <freebsd-security@freebsd.org>;
	Sat, 16 Jun 2012 18:14:13 +0000 (UTC)
Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587])
	(using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.sbone.de (Postfix) with ESMTPS id 5205825D389C;
	Sat, 16 Jun 2012 18:14:12 +0000 (UTC)
Received: from content-filter.sbone.de (content-filter.sbone.de
	[IPv6:fde9:577b:c1a9:31::2013:2742])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.sbone.de (Postfix) with ESMTPS id 4F0A3BE857E;
	Sat, 16 Jun 2012 18:14:11 +0000 (UTC)
X-Virus-Scanned: amavisd-new at sbone.de
Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587])
	by content-filter.sbone.de (content-filter.sbone.de
	[fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024)
	with ESMTP id gJcbf_SnU67X; Sat, 16 Jun 2012 18:14:09 +0000 (UTC)
Received: from orange-en1.sbone.de (orange-en1.sbone.de
	[IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3])
	(using TLSv1 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	by mail.sbone.de (Postfix) with ESMTPSA id A2453BE83AB;
	Sat, 16 Jun 2012 18:14:09 +0000 (UTC)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: "Bjoern A. Zeeb" <bz@freebsd.org>
In-Reply-To: <4FDCC91A.7080403@pyro.eu.org>
Date: Sat, 16 Jun 2012 18:14:08 +0000
Content-Transfer-Encoding: quoted-printable
Message-Id: <AD8A7E58-C531-4AED-9A9E-9A4773E46E73@freebsd.org>
References: <4FDCC91A.7080403@pyro.eu.org>
To: Steven Chamberlain <steven@pyro.eu.org>
X-Mailer: Apple Mail (2.1084)
X-Mailman-Approved-At: Sat, 16 Jun 2012 19:52:59 +0000
Cc: freebsd-security@freebsd.org
Subject: Re: SA-12:04 commit on RELENG_8_1 incorrect?
X-BeenThere: freebsd-security@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Security issues \[members-only posting\]"
	<freebsd-security.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-security>, 
	<mailto:freebsd-security-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-security>
List-Post: <mailto:freebsd-security@freebsd.org>
List-Help: <mailto:freebsd-security-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-security>, 
	<mailto:freebsd-security-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jun 2012 18:14:14 -0000

On 16. Jun 2012, at 17:57 , Steven Chamberlain wrote:

> Hi,
>=20
> This was the commit of SA-12:04.sysret to RELENG_7_4, which makes =
sense
> to me:
>=20
> =
http://svnweb.freebsd.org/base/releng/7.4/sys/amd64/amd64/trap.c?r1=3D2166=
18&r2=3D236953
>=20
> But when it was applied to RELENG_8_1, it looks wrong, as if it was
> applied in the wrong place.  The indentation is broken, and the code
> inserted looks like it wouldn't be effective:
>=20
> =
http://svnweb.freebsd.org/base/releng/8.1/sys/amd64/amd64/trap.c?revision=3D=
236953&view=3Dmarkup#l965
>=20
> Please could someone take a look at this and let me know if it was
> really intended.

That 8.1 one is definitively wrong and had gone unnoticed.  I'll make
sure it'll be fixed.   Thanks a lot for letting us know.

/bz

--=20
Bjoern A. Zeeb                                 You have to have visions!
   It does not matter how good you are. It matters what good you do!