Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Aug 2018 12:32:08 +0000 (UTC)
From:      Tobias Kortkamp <tobik@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r476986 - head/games/golly
Message-ID:  <201808121232.w7CCW8JX045136@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tobik
Date: Sun Aug 12 12:32:08 2018
New Revision: 476986
URL: https://svnweb.freebsd.org/changeset/ports/476986

Log:
  games/golly: Fix build on aarch64 or when objdump is missing
  
  Golly dlopens Python at runtime and looks up its shared library
  name during configure.  It first tries to do this using
  distutils.sysconfig.get_config_var("LDLIBRARY"), and then tries to
  use objdump if that fails.  Since the former is unlikely to ever
  fail on FreeBSD, objdump will never actually be called and we can
  pacify configure by pretending objdump is available.

Modified:
  head/games/golly/Makefile

Modified: head/games/golly/Makefile
==============================================================================
--- head/games/golly/Makefile	Sun Aug 12 12:20:35 2018	(r476985)
+++ head/games/golly/Makefile	Sun Aug 12 12:32:08 2018	(r476986)
@@ -12,14 +12,17 @@ COMMENT=	Conway's Game of Life and other cellular auto
 
 LICENSE=	GPLv2+
 
-BROKEN_aarch64=		fails to configure: missing objdump
-
 USES=		compiler:c++11-lib python:2.7
 USE_GL=		gl glu
 USE_WX=		3.0+
 
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS=	--with-wx-config=${WX_CONFIG:T}
+# Pretend objdump is available even if it is not e.g. on aarch64.
+# The Python shared library name is already looked up via
+# distutils.sysconfig.get_config_var("LDLIBRARY") which is unlikely
+# to fail; objdump is never actually used.
+CONFIGURE_ARGS=	ac_cv_prog_OBJDUMP=/usr/bin/false \
+		--with-wx-config=${WX_CONFIG:T}
 CXXFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201808121232.w7CCW8JX045136>