From owner-svn-src-head@freebsd.org Sun Oct 21 16:04:18 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01BDEFF7EAC; Sun, 21 Oct 2018 16:04:18 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9F60E94018; Sun, 21 Oct 2018 16:04:17 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 510AB1C24D; Sun, 21 Oct 2018 16:04:17 +0000 (UTC) (envelope-from gjb@freebsd.org) Date: Sun, 21 Oct 2018 16:04:15 +0000 From: Glen Barber To: Dimitry Andric Cc: Jan Beich , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339436 - in head: . contrib/gcc gnu/usr.bin/cc/cc_tools lib/clang release sys/conf sys/sys Message-ID: <20181021160415.GD13668@FreeBSD.org> References: <201810190037.w9J0blks031617@repo.freebsd.org> <20181021154520.GB13668@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PPYy/fEw/8QCHSq3" Content-Disposition: inline In-Reply-To: <20181021154520.GB13668@FreeBSD.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2018 16:04:18 -0000 --PPYy/fEw/8QCHSq3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 21, 2018 at 03:45:20PM +0000, Glen Barber wrote: > On Sun, Oct 21, 2018 at 11:55:20AM +0200, Dimitry Andric wrote: > > On 21 Oct 2018, at 04:08, Jan Beich wrote: > > >=20 > > > Glen Barber writes: > > >=20 > > >> Modified: head/lib/clang/llvm.build.mk > > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > >> --- head/lib/clang/llvm.build.mk Fri Oct 19 00:24:23 2018 (r339435) > > >> +++ head/lib/clang/llvm.build.mk Fri Oct 19 00:37:47 2018 (r339436) > > >> @@ -17,7 +17,7 @@ CFLAGS+=3D -I${LLVM_SRCS}/include > > >> CFLAGS+=3D -DLLVM_BUILD_GLOBAL_ISEL > > >> CFLAGS+=3D -D__STDC_LIMIT_MACROS > > >> CFLAGS+=3D -D__STDC_CONSTANT_MACROS > > >> -#CFLAGS+=3D -DNDEBUG > > >> +CFLAGS+=3D -DNDEBUG > > >=20 > > > Would Clang still hit asserts instead of crashing with cryptic messag= es? > >=20 > > In llvm, assertions (and various other internal consistency checks) are > > turned off by defining NDEBUG. So indeed, if something in the internal > > state goes in an unexpected direction, you could get crashes or other > > "interesting" effects. > >=20 > > That said, the resulting executable(s) should run somewhat faster, and > > be somewhat smaller. I think we have always done this for stable > > branches and releases. > >=20 >=20 > I think I screwed up, and changed this in the wrong branch. I'm looking > into the "why", but the commit to head in this case should be reverted > (I'll take care of it if it was not already done), and this particular > change should be applied to stable/12 (which I will also take care of). > I first want to look through our docs to understand how I messed this > up. >=20 Ok, reverted in head as of r339541, and the commit to apply the change to stable/12 is sent to re@ for approval. Glen --PPYy/fEw/8QCHSq3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAlvMo38ACgkQAxRYpUeP 4pMNJg/+PsEegAg3ctENiVnouQ3BNQaCZ+ev984qSf+THdBfR1PSZI9wimc3PryK Ma0jtZVx/q5ZhnNkTnSIRNwG8WRGuwCn3ep3r6DzkMcmD+KGdi54R0JRPOI5buH6 7iJk4mB9lMM3XikqjhuIYO79mtvxPIrZHHY0wXZpI5kxUTMIqj0vE29h1UnUj4GK o3c9jUWlOAwVS52J3oTDhFlZuyvWvkPePhAKyoXAmJndOuZLIKXsZbE6wXgK1GhX LLCJIIA4Ldw/iocNMWv2vAZdiC7yS+6ccJXUmAG5G2OX0gYAuLnbFUohUuNj87Ax 0A53SGGxzYGjnOXfToYJsZ+eT1Rcv4n3P2CFHMwAaPZjfNiys1bZ7USYYmVEszIQ 8gD6GXt7HO1BbcEux3KPtaboSN2a2jZiDnG8OYPNZnIDwGmerzcC5bh01p49SrJO ydHnqoA6rOXqc4du+p5c0DhYYrgfVWXCr7QXWZIhoN+L5LQKxWVFTrwoFiW78rmo HNiLvn2R6z1LASfJJ0ruZy/7Q/ek1et1WAhfGBUdH0OXW8q+xrH6QFp6E8c8Uy8H YS68Dp4CpK1fLYdQCpNa1A9IAzFuTma+1npwkbWTXCp9sPg8JcBCdMZhdmPVP454 XuP3+zGWXwNMTH0EZrIjl7/SPIEqvLWM4W7aG9rQv4TT+NXwzfU= =Yd9J -----END PGP SIGNATURE----- --PPYy/fEw/8QCHSq3--