From owner-freebsd-current@FreeBSD.ORG Sun Nov 28 00:30:47 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D20916A510 for ; Sun, 28 Nov 2004 00:30:47 +0000 (GMT) Received: from sccrmhc13.comcast.net (sccrmhc13.comcast.net [204.127.202.64]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9BA1343D66 for ; Sun, 28 Nov 2004 00:30:39 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from h00609772adf0.ne.client2.attbi.com ([66.30.114.143]) by comcast.net (sccrmhc13) with ESMTP id <20041128003038016001jqhce>; Sun, 28 Nov 2004 00:30:38 +0000 Received: from h00609772adf0.ne.client2.attbi.com (localhost [127.0.0.1]) iAS0Ubts000895; Sat, 27 Nov 2004 19:30:37 -0500 (EST) (envelope-from rodrigc@h00609772adf0.ne.client2.attbi.com) Received: (from rodrigc@localhost)iAS0Uap2000894; Sat, 27 Nov 2004 19:30:36 -0500 (EST) (envelope-from rodrigc) Date: Sat, 27 Nov 2004 19:30:36 -0500 From: Craig Rodrigues To: Vladimir Grebenschikov Message-ID: <20041128003036.GA883@crodrigues.org> References: <1101492325.996.54.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1101492325.996.54.camel@localhost> User-Agent: Mutt/1.4.1i cc: "current@freebsd.org" Subject: Re: ptrace broken on latest CURRENT ? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Nov 2004 00:30:48 -0000 On Fri, Nov 26, 2004 at 09:05:25PM +0300, Vladimir Grebenschikov wrote: > Hi > > % truss ls > truss: PIOCBIS: Inappropriate ioctl for device I'm seeing this too. This patch seems to work for me, but I don't know if it is correct or not. --- sys_generic.c.orig Sat Nov 27 19:14:39 2004 +++ sys_generic.c Sat Nov 27 19:17:09 2004 @@ -503,7 +503,7 @@ if ((size > IOCPARM_MAX) || ((com & (IOC_VOID | IOC_IN | IOC_OUT)) == 0) || ((com & IOC_VOID) && size > 0) || - ((com & (IOC_IN | IOC_OUT)) && size == 0)) { + ((com & IOC_OUT) && size == 0)) { fdrop(fp, td); return (ENOTTY); } -- Craig Rodrigues http://crodrigues.org rodrigc@crodrigues.org