From owner-freebsd-ports@FreeBSD.ORG Thu Dec 2 20:42:58 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A7F9F10656A6 for ; Thu, 2 Dec 2010 20:42:58 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 789B28FC12 for ; Thu, 2 Dec 2010 20:42:58 +0000 (UTC) Received: by iwn39 with SMTP id 39so10239188iwn.13 for ; Thu, 02 Dec 2010 12:42:57 -0800 (PST) Received: by 10.231.170.208 with SMTP id e16mr756410ibz.44.1291322577405; Thu, 02 Dec 2010 12:42:57 -0800 (PST) MIME-Version: 1.0 Received: by 10.231.79.82 with HTTP; Thu, 2 Dec 2010 12:42:36 -0800 (PST) In-Reply-To: <20101202175833.GG83341@libertas.local.camdensoftware.com> References: <20101202160617.GD83341@libertas.local.camdensoftware.com> <20101202175833.GG83341@libertas.local.camdensoftware.com> From: Eitan Adler Date: Thu, 2 Dec 2010 15:42:36 -0500 Message-ID: To: freebsd ports Content-Type: text/plain; charset=UTF-8 Subject: Re: updated dialog(1) replacement for ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2010 20:42:58 -0000 On Thu, Dec 2, 2010 at 12:58 PM, Chip Camden wrote: > Quoth Eitan Adler on Thursday, 02 December 2010: >> Thank you for your comments >> >> > Every keystroke causes the screen to completely repaint. >> This can't be fully helped. Any valid key stroke is going to cause >> this. However I did make invalid keystrokes skip the repainting. > > Ugh -- I haven't looked at the code yet, but even back in the curses days > (pre-ncurses) this problem had already been solved. The window layout looks like | Title | | primary | help | | license | | exit | And on every valid keystroke primary and help need to be refreshed. ncurses is optimized to handle this correctly. However the wborder command on "primary" and "help" for some reason touches "title" and "license" as well - so the doupdate() ncurses functions refreshes them as well. If you could find a way to solve the problem please let know - a patch would be better :-) >Heh -- sorry, I always begin my tests in "stupid user" mode. Thanks for > the patch! No problem - segfaults should be fixed :-) Again - thanks for your comments: I'd like to get this program into tip-top shape so when I get the bsd.port.mk patch I'll just submit a PR and wait for the flames :-) -- Eitan Adler