From owner-svn-ports-all@FreeBSD.ORG Fri Mar 20 18:43:26 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D7148DF0; Fri, 20 Mar 2015 18:43:26 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "adamw.org", Issuer "Gandi Standard SSL CA 2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4559F7AE; Fri, 20 Mar 2015 18:43:26 +0000 (UTC) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 9f357644; TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO; Fri, 20 Mar 2015 12:43:18 -0600 (MDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: svn commit: r381760 - in head/x11-fonts/sourcesanspro-ttf: . files From: Adam Weinberger In-Reply-To: <20150320183524.GD87678@ivaldir.etoilebsd.net> Date: Fri, 20 Mar 2015 12:43:17 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <9BE33FCA-5C2F-4FEA-9B3A-5D9DB6632635@adamw.org> References: <201503201823.t2KIN32I080448@svn.freebsd.org> <550C6655.5010802@FreeBSD.org> <20150320183524.GD87678@ivaldir.etoilebsd.net> To: Baptiste Daroussin X-Mailer: Apple Mail (2.2070.6) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Bryan Drewery X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 18:43:27 -0000 > On 20 Mar, 2015, at 12:35, Baptiste Daroussin = wrote: >=20 > On Fri, Mar 20, 2015 at 01:26:29PM -0500, Bryan Drewery wrote: >> On 3/20/2015 1:23 PM, Baptiste Daroussin wrote: >>> +WRKSRC=3D ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME:S,/,-,} >>=20 >> I think we should put this globally in this 1 line: >>=20 >> bsd.port.mk >> 1561 . if defined(GH_TAGNAME) >> 1562 WRKSRC?=3D ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME} >>=20 >>=20 >> After https://reviews.freebsd.org/D2103 is resolved I will fix that. >=20 > Almost in this case upstream decided to put a / in the TAGNAME which = is ... well > ... :) It would be so unbelievably nice if we had a way to just specify the = destination filename, using fetch -o. All the bizarre names that files = are published as, the unversioned tarballs, the documentation files = labelled Documentation.pdf, and the fallout from changes like this.... = we could make our lives so much easier with a DISTFILE_DEST variable. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org