From owner-dev-commits-src-main@freebsd.org Fri Jan 8 21:36:35 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A1C844D76FB; Fri, 8 Jan 2021 21:36:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DCGdH4C4yz3Jl6; Fri, 8 Jan 2021 21:36:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8306A2429; Fri, 8 Jan 2021 21:36:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 108LaZeA090867; Fri, 8 Jan 2021 21:36:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 108LaZj7090866; Fri, 8 Jan 2021 21:36:35 GMT (envelope-from git) Date: Fri, 8 Jan 2021 21:36:35 GMT Message-Id: <202101082136.108LaZj7090866@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: cbc9be948a3b - main - sifive_uart: quiet GCC -Werror=parentheses MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cbc9be948a3bd6ff0f142b8fe995c27d7a06b536 Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 21:36:35 -0000 The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=cbc9be948a3bd6ff0f142b8fe995c27d7a06b536 commit cbc9be948a3bd6ff0f142b8fe995c27d7a06b536 Author: Mitchell Horne AuthorDate: 2021-01-08 21:06:11 +0000 Commit: Mitchell Horne CommitDate: 2021-01-08 21:32:18 +0000 sifive_uart: quiet GCC -Werror=parentheses Add an additional set of braces to clarify intention. The '&' operator has a higher precedence than '|', but the reader may not always remember this. No functional change. --- sys/riscv/sifive/sifive_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/riscv/sifive/sifive_uart.c b/sys/riscv/sifive/sifive_uart.c index e06d1fc0b727..cee9ddd0bc25 100644 --- a/sys/riscv/sifive/sifive_uart.c +++ b/sys/riscv/sifive/sifive_uart.c @@ -279,7 +279,7 @@ sfuart_bus_flush(struct uart_softc *sc, int what) if (c) \ i |= ((i) & (s)) ? (s) : (s) | (d); \ else \ - i = ((i) & (s)) ? (i) & ~(s) | (d) : (i); \ + i = ((i) & (s)) ? ((i) & ~(s)) | (d) : (i); \ } while (0) static int