Date: Mon, 28 Dec 2020 13:37:44 GMT From: Hans Petter Selasky <hselasky@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: aca12148b113 - main - Improve error message printing in krping. Don't print completion queue flush as an error. Message-ID: <202012281337.0BSDbiUw058256@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=aca12148b113b618afc19028c656a7ac4434231d commit aca12148b113b618afc19028c656a7ac4434231d Author: Hans Petter Selasky <hps@selasky.org> AuthorDate: 2020-12-09 12:59:01 +0000 Commit: Hans Petter Selasky <hselasky@FreeBSD.org> CommitDate: 2020-12-28 13:37:09 +0000 Improve error message printing in krping. Don't print completion queue flush as an error. MFC after: 1 week Sponsored by: Mellanox Technologies // NVIDIA Networking --- sys/contrib/rdma/krping/krping.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sys/contrib/rdma/krping/krping.c b/sys/contrib/rdma/krping/krping.c index c734da36247f..e9a379984dec 100644 --- a/sys/contrib/rdma/krping/krping.c +++ b/sys/contrib/rdma/krping/krping.c @@ -362,10 +362,6 @@ static void krping_cq_event_handler(struct ib_cq *cq, void *ctx) int ret; BUG_ON(cb->cq != cq); - if (cb->state == ERROR) { - printk(KERN_ERR PFX "cq completion in ERROR state\n"); - return; - } if (cb->frtest) { printk(KERN_ERR PFX "cq completion event in frtest!\n"); return; @@ -384,7 +380,10 @@ static void krping_cq_event_handler(struct ib_cq *cq, void *ctx) goto error; } } - + if (cb->state == ERROR) { + printk(KERN_ERR PFX "cq completion in ERROR state\n"); + return; + } switch (wc.opcode) { case IB_WC_SEND: DEBUG_LOG("send completion\n");
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202012281337.0BSDbiUw058256>