From owner-freebsd-java@FreeBSD.ORG Wed Nov 19 04:14:38 2014 Return-Path: Delivered-To: java@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A69E98E1 for ; Wed, 19 Nov 2014 04:14:38 +0000 (UTC) Received: from smtp.rcn.com (smtp.rcn.com [69.168.97.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 68A2D5F6 for ; Wed, 19 Nov 2014 04:14:37 +0000 (UTC) X_CMAE_Category: , , X-CNFS-Analysis: v=2.0 cv=YIodOG6x c=1 sm=1 a=dUPDVWa3Dxp/u6Q+mY+wRA==:17 a=kZuBgiGTSrQA:10 a=kj9zAlcOel0A:10 a=LaogzpLLAAAA:8 a=5y4faFyK3SkA:10 a=6I5d2MoRAAAA:8 a=DPV2o3IkQXLZi9hVsCAA:9 a=CjuIK1q_8ugA:10 a=dUPDVWa3Dxp/u6Q+mY+wRA==:117 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: YW5hdEByY24uY29t Authentication-Results: smtp02.rcn.cmh.synacor.com smtp.mail=mi@aldan.algebra.com; spf=neutral; sender-id=neutral Authentication-Results: smtp02.rcn.cmh.synacor.com header.from=mi@aldan.algebra.com; sender-id=neutral Authentication-Results: smtp02.rcn.cmh.synacor.com smtp.user=anat; auth=pass (LOGIN) Received-SPF: neutral (smtp02.rcn.cmh.synacor.com: 100.1.235.44 is neither permitted nor denied by domain of aldan.algebra.com) Received: from [100.1.235.44] ([100.1.235.44:22547] helo=narawntapu.narawntapu) by smtp.rcn.com (envelope-from ) (ecelerity 3.6.2.43620 r(Platform:3.6.2.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id E9/F4-27239-A291C645; Tue, 18 Nov 2014 23:14:36 -0500 Received: from narawntapu.narawntapu (localhost [127.0.0.1]) by narawntapu.narawntapu (8.14.9/8.14.5) with ESMTP id sAJ4EVnu002188 for ; Tue, 18 Nov 2014 23:14:32 -0500 (EST) (envelope-from mi@narawntapu.narawntapu) Received: (from mi@localhost) by narawntapu.narawntapu (8.14.9/8.14.5/Submit) id sAJ4EViH002181 for java@FreeBSD.org; Tue, 18 Nov 2014 23:14:31 -0500 (EST) (envelope-from mi) From: "Mikhail T." Message-Id: <201411190414.sAJ4EViH002181@narawntapu.narawntapu> Subject: opendjk-8 fails to extract To: java@FreeBSD.org Date: Tue, 18 Nov 2014 23:14:31 -0500 (EST) Reply-To: mi@aldan.algebra.com X-Face: %UW#n0|w>ydeGt/b@1-.UFP=K^~-:0f#O:D7w hJ5G_<5143Bb3kOIs9XpX+"V+~$adGP:J|SLieM31VIhqXeLBli" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Nov 2014 04:14:38 -0000 Hello! I wanted to build java/opendjk8, but it kept failing to extract: unzip was complaining about "invalid archive". That's probably because the port uses both .zip and .tar.gz files -- and BOTH are fed to unzip. This breaks things -- at least, when archivers/unzip is installed (and used) instead of the /usr/bin/unzip. Instead of guessing that, the below patch changes the Makefile so that tar(1) is used for both files instead. Our tar will eat anything today. Yours, -mi Index: Makefile =================================================================== --- Makefile (revision 372759) +++ Makefile (working copy) @@ -9,7 +9,7 @@ LOCAL/jkim:jdk,jtreg PKGNAMESUFFIX?= ${JDK_MAJOR_VERSION} DISTNAME= ${PORTNAME}-${JDK_MAJOR_VERSION}-src-b${DIST_BUILD_NUMBER}-03_mar_2014 -DISTFILES= ${DISTNAME}${EXTRACT_SUFX}:jdk +DISTFILES= ${DISTNAME}.zip:jdk MAINTAINER= java@FreeBSD.org COMMENT?= Java Development Kit ${JDK_MAJOR_VERSION} @@ -26,7 +26,7 @@ RUN_DEPENDS= javavm:${PORTSDIR}/java/javavmwrapper \ ${LOCALBASE}/lib/X11/fonts/dejavu:${PORTSDIR}/x11-fonts/dejavu -USES= compiler:features dos2unix gmake iconv pkgconfig shebangfix zip +USES= compiler:features dos2unix gmake iconv pkgconfig shebangfix USE_AUTOTOOLS= autoconf USE_XORG= x11 xext xi xrender xt xtst