From owner-freebsd-toolchain@freebsd.org Fri Jun 7 23:09:34 2019 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 44AF815B989F for ; Fri, 7 Jun 2019 23:09:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D1A998E366 for ; Fri, 7 Jun 2019 23:09:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 94E8D15B989D; Fri, 7 Jun 2019 23:09:33 +0000 (UTC) Delivered-To: toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7254C15B989C for ; Fri, 7 Jun 2019 23:09:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0BA6C8E365 for ; Fri, 7 Jun 2019 23:09:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 20DBE9A9C for ; Fri, 7 Jun 2019 23:09:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x57N9WwU029196 for ; Fri, 7 Jun 2019 23:09:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x57N9VjC029193 for toolchain@FreeBSD.org; Fri, 7 Jun 2019 23:09:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: toolchain@FreeBSD.org Subject: [Bug 238404] AddressSanitizer should intercept pthread_get_name_np (FreeBSD), not pthread_getname_np (Glibc) symbol Date: Fri, 07 Jun 2019 23:09:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: toolchain@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jun 2019 23:09:34 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238404 Bug ID: 238404 Summary: AddressSanitizer should intercept pthread_get_name_np (FreeBSD), not pthread_getname_np (Glibc) symbol Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: toolchain@FreeBSD.org Reporter: jbeich@FreeBSD.org AC_CHECK_FUNCS() doesn't check declaration, only library symbol. For one, FreeBSD never had pthread_getname_np() but added a similar function in base r337983. See contrib/compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.= inc $ cat >a.c char pthread_getname_np(); int main() { pthread_getname_np(); return 0; } $ cc a.c -fsanitize=3Daddress $ cc a.c ld: error: undefined symbol: pthread_getname_np >>> referenced by a.c >>> /tmp/a-101e7b.o:(main) cc: error: linker command failed with exit code 1 (use -v to see invocation) $ pkg install python27 $ hash git 2>/dev/null || pkg install mercurial $ hg clone https://hg.mozilla.org/mozilla-unified firefox || git clone https://github.com/mozilla/gecko-dev firefox $ cd firefox $ hg update central || git checkout origin/master $ echo "ac_add_options --with-libclang-path=3D${LOCALBASE-/usr/local}/llvm8= 0/lib" >>.mozconfig $ echo "ac_add_options --enable-address-sanitizer" >>.mozconfig $ ./mach bootstrap # select Firefox for Desktop $ ./mach build [...] In file included from objdir/js/src/Unified_cpp_js_src9.cpp:29: js/src/threading/posix/Thread.cpp:174:8: error: use of undeclared identifier 'pthread_getname_np'; did you mean 'pthread_get_name_np'? rv =3D pthread_getname_np(pthread_self(), nameBuffer, len); ^~~~~~~~~~~~~~~~~~ pthread_get_name_np /usr/include/pthread_np.h:52:6: note: 'pthread_get_name_np' declared here void pthread_get_name_np(pthread_t, char *, size_t); ^ In file included from objdir/js/src/Unified_cpp_js_src9.cpp:29: js/src/threading/posix/Thread.cpp:174:8: error: assigning to 'int' from incompatible type 'void' rv =3D pthread_getname_np(pthread_self(), nameBuffer, len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 errors generated. --=20 You are receiving this mail because: You are the assignee for the bug.=