Date: Fri, 07 Apr 2017 22:23:18 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Matthew Rezny <rezny@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r437953 - in head/lang/beignet: . files Message-ID: <a87s-otl5-wny@FreeBSD.org> In-Reply-To: <201704071930.v37JUBGj017948@repo.freebsd.org> (Matthew Rezny's message of "Fri, 7 Apr 2017 19:30:11 %2B0000 (UTC)") References: <201704071930.v37JUBGj017948@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Rezny <rezny@FreeBSD.org> writes:
> - Enable OpenCL 2.0 on AMD64
Isn't this premature before 1.3.2 or bug 217635 fix?
> +USE_LDCONFIG= ${LOCALBASE}/lib/${PORTNAME}
Why do you need ldconfig hints for dlopen(3)? libcl.so embeds absolute
paths for libgbe.so and libgbeinterp.so + absolute path via ocl-icd
config in /usr/local/etc/OpenCL/vendors/intel-beignet.icd
Please, don't turn portlint into a cargo cult.
> +LLVMVER= ${MESA_LLVM_VER:U39}
Why not drop LLVMVER variable and use MESA_LLVM_VER directly?
BUILD_DEPENDS= clang${MESA_LLVM_VER}:devel/llvm${MESA_LLVM_VER} \
[...]
MESA_LLVM_VER?= 39
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a87s-otl5-wny>