From owner-cvs-src@FreeBSD.ORG Sun Aug 27 17:01:26 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 884C816A4F4; Sun, 27 Aug 2006 17:01:26 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1907C45F8B; Sun, 27 Aug 2006 16:46:24 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k7RGj06t055206; Sun, 27 Aug 2006 10:45:01 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 27 Aug 2006 10:45:10 -0600 (MDT) Message-Id: <20060827.104510.1649770194.imp@bsdimp.com> To: wb@freebie.xs4all.nl From: "M. Warner Losh" In-Reply-To: <20060826082751.GA11942@freebie.xs4all.nl> References: <20060826020854.GD16768@turion.vk2pj.dyndns.org> <20060826023120.GA74468@troutmask.apl.washington.edu> <20060826082751.GA11942@freebie.xs4all.nl> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sun, 27 Aug 2006 10:45:02 -0600 (MDT) Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, cvs-all@freebsd.org, sgk@troutmask.apl.washington.edu, cvs-src@freebsd.org, guido@gvr.org, kabaev@gmail.com Subject: Re: cvs commit: src/contrib/ipfilter HISTORY Makefile bpf_filter.c ip_fil.c ipf.h ipmon.h ipt.h kmem.h mlfk_rule.c opts.h radix.c radix_ipf.h snoop.h src/contrib/ipfilter/BSD Makefile Makefile.ipsend kupgrade src/contrib/ipfilter/iplang iplang_l.l ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Aug 2006 17:01:26 -0000 In message: <20060826082751.GA11942@freebie.xs4all.nl> Wilko Bulte writes: : On Fri, Aug 25, 2006 at 07:31:20PM -0700, Steve Kargl wrote.. : > On Sat, Aug 26, 2006 at 12:08:54PM +1000, Peter Jeremy wrote: : > > On Thu, 2006-Aug-24 18:44:02 -0400, Alexander Kabaev wrote: : > > >personally. The mistake you made just shows how important it is to do a : > > >buildworld _from freshly checked out sources_ after every major vendor : > > >import. : > > : > > I'm not sure how doing this would have prevented the breakage. It : > > might have allowed Guido to notice the breakage more quickly. : > : > It would have caught the first problem, which I reported here : > http://lists.freebsd.org/pipermail/freebsd-current/2006-August/065175.html. : > This problem was fixed by kan as noted here : > http://lists.freebsd.org/pipermail/cvs-src/2006-August/067536.html : > : > Notice I reported the problem of Aug 16th. Kan's patch was committed : > on Aug 17th. : > : > > Guido made a mistake, has apologised and has corrected the problem in : > > less than 6 hours. : > : > He only corrected the second problem caused by his commit. : : Can we please stop this moaning about Guido's work? Mistakes do get : made, and in this case were fixed rapidly. Yes. The number of commits that I've actually pulled a fresh world and built after are in the low double digits (compared with ~3000 total commits). The number of times I've broken the tree is also in the low double digits. I don't find the return on investment of always doing a full build on a fresh tree worth the effort. I think I've done a full make universe after a set of commits twice, and those were esepcially risky changes. People need to understand that mistakes happen from time to time. These mistakes do cost other people time, so they should be avoided as much as possible, and forgiven when they happen. We do not have a major problem with tree breakage, despite what some would say. The tree usually builds, and usually works. It is the few times that it doesn't that stand in stark contrast... Warner