From owner-freebsd-net@FreeBSD.ORG Fri Mar 18 08:28:14 2005 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C655C16A4CE for ; Fri, 18 Mar 2005 08:28:14 +0000 (GMT) Received: from mail24.sea5.speakeasy.net (mail24.sea5.speakeasy.net [69.17.117.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8114043D49 for ; Fri, 18 Mar 2005 08:28:14 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 19965 invoked from network); 18 Mar 2005 08:28:14 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail24.sea5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 18 Mar 2005 08:28:13 -0000 Received: from hydrogen.funkthat.com (sbapqb@localhost.funkthat.com [127.0.0.1])j2I8SCGH053236; Fri, 18 Mar 2005 00:28:13 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id j2I8SB8Q053235; Fri, 18 Mar 2005 00:28:11 -0800 (PST) Date: Fri, 18 Mar 2005 00:28:10 -0800 From: John-Mark Gurney To: Mike Silbersack Message-ID: <20050318082810.GC37984@funkthat.com> Mail-Followup-To: Mike Silbersack , freebsd-net@FreeBSD.org References: <20050317221359.GN89312@funkthat.com> <20050318021907.H844@odysseus.silby.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050318021907.H844@odysseus.silby.com> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: freebsd-net@FreeBSD.org Subject: Re: changes to make ethernet packets able to be unaligned... X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2005 08:28:14 -0000 Mike Silbersack wrote this message on Fri, Mar 18, 2005 at 02:21 -0600: > > On Thu, 17 Mar 2005, John-Mark Gurney wrote: > > >Ok, since you wanted to look at it more... I have a working copy of > >making packets alignment safe for ip in p4 at as change 73150: > >http://perforce.freebsd.org/changeView.cgi?CH=73150&ignore=GO%21 > > > >This currently is only for arm and I plan to now remove the code from > >epe.c that copies the packet around since it's really stupid, and > >considering how easily NetBSD did this (it took about about 5 minutes > >to get this code running), I'm ashamed that I didn't do this a while > >back when I was working on if_re... > > > >Comments please? > > I'm confused - don't sparc64 and alpha have similar alignment > requirements? Why does arm require code changes? yes, the alignment constraints for arm are the same.. the reason I said the above is only for arm is the epe driver (which is only on an ARM core) has been made to use the new feature... The changes to ip_input.c will work with other drivers as well... it just needs to make sure that the proper defines are in amd64 and i386 so that we don't do the fix up when we don't need to... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."