From owner-svn-src-all@freebsd.org Sat Dec 10 10:12:06 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77251C70533; Sat, 10 Dec 2016 10:12:06 +0000 (UTC) (envelope-from kostik@kib.kiev.ua) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E5EEA8D1; Sat, 10 Dec 2016 10:12:05 +0000 (UTC) (envelope-from kostik@kib.kiev.ua) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id uBAABseQ004130 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 10 Dec 2016 12:11:54 +0200 (EET) (envelope-from kostik@tom.home) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua uBAABseQ004130 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id uBAABsJ3004129; Sat, 10 Dec 2016 12:11:54 +0200 (EET) (envelope-from kostik) From: Konstantin Belousov Date: Sat, 10 Dec 2016 12:11:54 +0200 To: Conrad Meyer Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, emaste@freebsd.org Subject: Re: svn commit: r308212 - in head/sys: fs/nfsserver kern sys Message-ID: <20161210101154.GM54029@kib.kiev.ua> References: <201611021243.uA2ChGIg003295@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: jrom: Konstantin Belousov User-Agent: Mutt/1.7.1 (2016-10-04) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Dec 2016 10:12:06 -0000 On Fri, Dec 09, 2016 at 12:13:09PM -0800, Conrad Meyer wrote: > On Wed, Nov 2, 2016 at 5:43 AM, Konstantin Belousov wrote: > > Author: kib > > Date: Wed Nov 2 12:43:15 2016 > > New Revision: 308212 > > URL: https://svnweb.freebsd.org/changeset/base/308212 > > > > Log: > > Allow some dotdot lookups in capability mode. > > > > If dotdot lookup does not escape from the file descriptor passed as > > the lookup root, we can allow the component traversal. Track the > > directories traversed, and check the result of dotdot lookup against > > the recorded list of the directory vnodes. > > > > Dotdot lookups are enabled by sysctl vfs.lookup_cap_dotdot, currently > > disabled by default until more verification of the approach is done. > > Hi Konstantin, > > Are we waiting on a specific reviewer or something else? It would be > very nice to have this enabled by default. I did waited for some review, but it obviously not going to happen. Please push the button for D8746, and I will commit the change.