From nobody Sat Aug 8 00:44:08 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hH2MY3Hqbz6mZPY for ; Sat, 08 Aug 2026 00:44:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hH2MY03Pqz3wkF for ; Sat, 08 Aug 2026 00:44:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786149849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tGpyK41JkdOiSkGw81yFy73YjYqaBEhkEdJfQfHnqaE=; b=nT1fJM+vPHQpR2xtZbnsxxslKG+Kihy5LVIfn5Yke6XZlnPhgg4kz9Gqxf6MXu/EwCmpQU P5Hu4Y5FsNOFT/7pmI1IZuDT9PN405SHyYFUtNp39XnIwyV6UUx/4riCJNdSdZmuRxRyda DNA5kORVMfCth3bHyNXWis8OuuPDn12iKkfkjjcOhZ3rUnPJzNkqD+yv865u4f9m4IQnVQ aMo8gmve+ZJf9h/UseWnXaWH1beX2ADmQEIM5WVnrn1mtk/zQ/Q/5I7jonZTr65bHULLvz anSP2XPS7cW0lKUcUIulJQXfRG1b/DHmceKOMMlbdCm+gBPUdyH9S89EKd8PKA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786149849; a=rsa-sha256; cv=none; b=JS4urErNIs0VWoQKOFP14DTnsyshb+OPf8/nSNxz6nSl5lgo7zshR3UlpDbXgk/me0w49Y 544HYELnjppT6qrbzw4VKLCGvljbcSPgrmz/T9TxU6XT0tNGq009lmcjV/Kk6Xz3XPnjiM BZMA9xDso7DFh2dAv4XicT9GVWm1E6TJtQBVxvgFV4hx8pkVeXcE+jcSd1ajhDJ5ycyRmu jGklLEWU16XE8aSSkVpyfeQbuEB+BImVSE6D0mpSitm+MbcWhwnjE52wKJEetIEfgSBanI aPe2SBsrbvtU6x4+cTIvGMwOeOdhShp/h1wNjoTbUho26g7oknZlu4F2+LJqfw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786149849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tGpyK41JkdOiSkGw81yFy73YjYqaBEhkEdJfQfHnqaE=; b=n2dgkkOabs01hOTzQvK2eFQ7dF0n+TJaCBt3AgEcthPmw6luD36lQ4cIp/5ZGwng52H+lx 7qLhVR+wFtbRLtMtFruokWGZKiq9BQZHpSohE6YaGuWSmf4x4OxAvzWEtvZHNM3CeWzrmG oAbySs6s5AhNbtzf6eot8Mof5pabasokzDAt7f48v+Kj7BIwoqo6yA9tmBRkr4doYSPqlE abBlVUOyEpUCJeVm9oIa8SlT8u0wYZ+mRqN1fVKNWGjiIgmujHV5fVuo4uyJPuylG1+VeK 4njNKzpZSdlucW82zeVYGBSanzGGeQnjC6eaFDmnutMJsN0Fl4gSB7nnUwZjnQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hH2MX6BxPz18D for ; Sat, 08 Aug 2026 00:44:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3fbb5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 08 Aug 2026 00:44:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: c50447c7075e - stable/14 - ixgbe: fix unaligned access in ixgbe_update_flash_X550() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c50447c7075e58c7d02279b37735f101b093087f Auto-Submitted: auto-generated Date: Sat, 08 Aug 2026 00:44:08 +0000 Message-Id: <6a767bd8.3fbb5.60cb16b2@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=c50447c7075e58c7d02279b37735f101b093087f commit c50447c7075e58c7d02279b37735f101b093087f Author: Kevin Bowling AuthorDate: 2026-07-28 11:09:39 +0000 Commit: Kevin Bowling CommitDate: 2026-08-08 00:41:56 +0000 ixgbe: fix unaligned access in ixgbe_update_flash_X550() ixgbe_host_interface_command() treats its buffer as a u32 array. The local union contained only byte-sized fields, giving it one-byte stack alignment and allowing unaligned accesses on strict-align systems. Add a u32 member to the union to provide the required alignment and pass that member to ixgbe_host_interface_command(). No functional change is expected on x86. Obtained from: Intel ix 3.4.39 (cherry picked from commit 8fa2a7503468abb5f863729c4e244d738239503d) --- sys/dev/ixgbe/ixgbe_type.h | 1 + sys/dev/ixgbe/ixgbe_x550.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixgbe/ixgbe_type.h b/sys/dev/ixgbe/ixgbe_type.h index 4e242b7189cb..80f8effca6d5 100644 --- a/sys/dev/ixgbe/ixgbe_type.h +++ b/sys/dev/ixgbe/ixgbe_type.h @@ -3273,6 +3273,7 @@ struct ixgbe_hic_hdr2_rsp { }; union ixgbe_hic_hdr2 { + u32 buf[1]; struct ixgbe_hic_hdr2_req req; struct ixgbe_hic_hdr2_rsp rsp; }; diff --git a/sys/dev/ixgbe/ixgbe_x550.c b/sys/dev/ixgbe/ixgbe_x550.c index 7f07190f832c..f6ce0d10b9e2 100644 --- a/sys/dev/ixgbe/ixgbe_x550.c +++ b/sys/dev/ixgbe/ixgbe_x550.c @@ -3557,8 +3557,7 @@ s32 ixgbe_update_flash_X550(struct ixgbe_hw *hw) buffer.req.buf_lenl = FW_SHADOW_RAM_DUMP_LEN; buffer.req.checksum = FW_DEFAULT_CHECKSUM; - status = ixgbe_host_interface_command(hw, (u32 *)&buffer, - sizeof(buffer), + status = ixgbe_host_interface_command(hw, buffer.buf, sizeof(buffer), IXGBE_HI_COMMAND_TIMEOUT, false); return status;