From owner-svn-src-head@FreeBSD.ORG Sat Jul 12 15:58:57 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F1E57C5D; Sat, 12 Jul 2014 15:58:56 +0000 (UTC) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask.apl.washington.edu", Issuer "troutmask.apl.washington.edu" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CC3372DC1; Sat, 12 Jul 2014 15:58:56 +0000 (UTC) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.9/8.14.9) with ESMTP id s6CFwjYU078295 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 12 Jul 2014 08:58:45 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.9/8.14.9/Submit) id s6CFwjaM078294; Sat, 12 Jul 2014 08:58:45 -0700 (PDT) (envelope-from sgk) Date: Sat, 12 Jul 2014 08:58:45 -0700 From: Steve Kargl To: Ian Lepore Subject: Re: svn commit: r268566 - head/usr.bin/users Message-ID: <20140712155845.GA78259@troutmask.apl.washington.edu> References: <201407120747.s6C7lpYE020200@svn.freebsd.org> <20140712195452.N3279@besplex.bde.org> <53C12C1D.8080101@fastmail.net> <20140712132705.GA45964@FreeBSD.org> <1405179083.91430.14.camel@revolution.hippie.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405179083.91430.14.camel@revolution.hippie.lan> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Alexey Dokuchaev , src-committers@freebsd.org, svn-src-all@freebsd.org, David Chisnall , Bruce Simpson , Bruce Evans , svn-src-head@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jul 2014 15:58:57 -0000 On Sat, Jul 12, 2014 at 09:31:23AM -0600, Ian Lepore wrote: > On Sat, 2014-07-12 at 13:27 +0000, Alexey Dokuchaev wrote: > > On Sat, Jul 12, 2014 at 01:37:49PM +0100, Bruce Simpson wrote: > > > On 12/07/2014 12:34, Bruce Evans wrote: > > > >This joke is bad. The C++ version is worse in every way. > > > > > > I concur with everything you have said in your message. Moral of story: it > > > is very, very easy to introduce bloat using C++, and using a higher level > > > language does not automatically lead to better code quality. > > > > +1. Now the question is, how do we come out of this mess? Shall we redo > > it in C again? Polish C++ version? Merge it with w(1) as suggested? > > > > ./danfe > > > > It is in no way established that any kind of "mess" exists. All we have > is some people who appear to hate C++ expressing their opinions about > how they hate C++. All the whining about how many more bytes the > compiled code is or many milliseconds something takes to compile don't > add up to any actual problem. > > My opinion is that the original commit message was exactly correct: The > code was rewritten to be cleaner and easier to understand and maintain. > We need more of the same. > Go back and re-read Bruce's email. The massive compile-time pessimization caused by clang needs to be addressed before more C++ code is introduced into src/ -- Steve