From owner-cvs-sys  Sun Sep 21 15:59:17 1997
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id PAA23331
          for cvs-sys-outgoing; Sun, 21 Sep 1997 15:59:17 -0700 (PDT)
Received: from ns.mt.sri.com (SRI-56K-FR.mt.net [206.127.65.42])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id PAA23301;
          Sun, 21 Sep 1997 15:57:37 -0700 (PDT)
Received: from rocky.mt.sri.com (rocky.mt.sri.com [206.127.76.100])
	by ns.mt.sri.com (8.8.7/8.8.7) with ESMTP id QAA07264;
	Sun, 21 Sep 1997 16:57:35 -0600 (MDT)
Received: (from nate@localhost) by rocky.mt.sri.com (8.7.5/8.7.3) id QAA28083; Sun, 21 Sep 1997 16:57:34 -0600 (MDT)
Date: Sun, 21 Sep 1997 16:57:34 -0600 (MDT)
Message-Id: <199709212257.QAA28083@rocky.mt.sri.com>
From: Nate Williams <nate@mt.sri.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: John Dyson <dyson@freebsd.org>
Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-sys@freebsd.org
Subject: Re: cvs commit: src/sys/net ppp_deflate.c
In-Reply-To: <199709212231.PAA13771@freefall.freebsd.org>
References: <199709212231.PAA13771@freefall.freebsd.org>
X-Mailer: VM 6.29 under 19.15 XEmacs Lucid
Sender: owner-cvs-sys@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

John Dyson writes:
> dyson       1997/09/21 15:31:22 PDT
> 
>   Modified files:
>     sys/net              ppp_deflate.c 
>   Log:
>   Remove an unfortunate name clash with the zalloc/zfree routines.  Since the
>   ppp_deflate code uses the names locally - it looses.

Since the ppp code is 'externally' maintained code, did you submit this
patch to the author?  If not, then we have to keep maintaining this
change everytime we update it, which would imply that it would be easier
to change the 'locally' maintained code.

(Also, changing legacy code that uses names recently introduced seems
silly, since the old names already existed.)


Nate