From owner-cvs-all  Sun Jul 22 18:44:20 2001
Delivered-To: cvs-all@freebsd.org
Received: from assaris.sics.se (dhcp114.iss.kth.se [130.237.7.114])
	by hub.freebsd.org (Postfix) with ESMTP
	id EBEB337B401; Sun, 22 Jul 2001 18:44:15 -0700 (PDT)
	(envelope-from assar@assaris.sics.se)
Received: (from assar@localhost)
	by assaris.sics.se (8.9.3/8.9.3) id DAA33247;
	Mon, 23 Jul 2001 03:44:32 +0200 (CEST)
	(envelope-from assar)
To: Brian Somers <brian@Awfulhak.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libutil ecalloc.c emalloc.3 emalloc.c erealloc.c estrdup.c Makefile libutil.h
References: <200107230137.f6N1bfg13122@hak.lan.Awfulhak.org>
From: Assar Westerlund <assar@FreeBSD.org>
Date: 23 Jul 2001 03:44:32 +0200
In-Reply-To: Brian Somers's message of "Mon, 23 Jul 2001 02:37:41 +0100"
Message-ID: <5l4rs4h11b.fsf@assaris.sics.se>
Lines: 27
User-Agent: Gnus/5.070098 (Pterodactyl Gnus v0.98) Emacs/20.6
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Brian Somers <brian@Awfulhak.org> writes:
>   ptr = emalloc(n);
> 
> will mean nothing to a regular C programmer (except that it's 
> probably doing a malloc with some extra stuff).

Is it more obvious having xmalloc, xlmalloc, safe_malloc and all the
other names that this function has been called in different programs?

>   if ((ptr = malloc(n)) == NULL) {
>     fprintf(stderr, "malloc %lu failed\n", (unsigned long)n);
>     exit(1);
>   }
> 
> would actually be portable.

Sure, and you would have 17 different versions of these, printing
different messages and sometimes not bothering to check the return
value at all.

> Adding routines such as these to our libraries and then using them 
> from our programs just makes it irritating when you try to build 
> something on another OS -- not to mention obfuscating our code base.

Just build an emalloc on that other OS.  It's not a new problem.

/assar

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message