From owner-freebsd-net  Sat Feb 24 11:20:49 2001
Delivered-To: freebsd-net@freebsd.org
Received: from alpo.whistle.com (s206m1.whistle.com [207.76.206.1])
	by hub.freebsd.org (Postfix) with ESMTP id 7242837B4EC
	for <net@FreeBSD.ORG>; Sat, 24 Feb 2001 11:20:46 -0800 (PST)
	(envelope-from mark@whistle.com)
Received: from [10.1.10.113] ([10.1.10.113])
	by alpo.whistle.com (8.9.1a/8.9.1) with ESMTP id LAA65820;
	Sat, 24 Feb 2001 11:19:08 -0800 (PST)
Mime-Version: 1.0
X-Sender: mark@207.76.206.1
Message-Id: <p05100104b6bdb7b22391@[10.1.10.113]>
In-Reply-To: 
 <Pine.BSF.4.32.0101252250480.10921-100000@husten.security.at12.de>
References: 
 <Pine.BSF.4.32.0101252250480.10921-100000@husten.security.at12.de>
Date: Sat, 24 Feb 2001 11:19:02 -0800
To: Paul Herman <pherman@frenchfries.net>,
	Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
From: Mark Peek <mark@whistle.com>
Subject: Re: I have delayed ACK problems
Cc: Jonathan Lemon <jlemon@flugsvamp.com>, <net@FreeBSD.ORG>
Content-Type: text/plain; charset="us-ascii" ; format="flowed"
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

At 11:19 PM +0100 1/25/01, Paul Herman wrote:
>On Thu, 25 Jan 2001, Garrett Wollman wrote:
>
>>  <<On Thu, 25 Jan 2001 11:14:03 -0600 (CST), Jonathan Lemon 
>><jlemon@flugsvamp.com> said:
>>
>>  The important part was the
>>	if (callout_pending(tp->tt_delack)) {
>>		...
>>		tp->t_flags |= TF_ACKNOW;
>>	}
>>
>>  bit.  This causes us to ack immediately where previously we would just
>>  delay an already-schedule delayed ack.
>
>Yep, that does it.  Simple.  Elegant.  I see now why my (bloated
>unintelligible) patch worked, it also didn't reset the timer when a
>delayed ack might have already been pending.
>
>OK, there are other parts of the code that do the same thing
>(TCP_REASS, SYN was ACKed, et. al.) but if no one objects, I'll
>send-pr the patch to be commited.

Was there ever a final resolution to this problem? I checked CVS and 
there didn't appear to be any code changes made as a result of this 
discussion. If this was a real problem, I'm wondering whether it 
should be checked into -current and considered for MFC into 4.3.

Thanks,
Mark

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message