From nobody Fri Oct 10 23:32:29 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ck31n6pk4z6CBKJ; Fri, 10 Oct 2025 23:32:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ck31n6LM9z3Rwl; Fri, 10 Oct 2025 23:32:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760139149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AREahMqdbiFQBxR4MPq42IpebJvtuCQBJg8DLd+RzhU=; b=t/QqrsOH/hCOaSc0JKvqRfwh/F1kBPQ/Bw3jJA6VTBMgOhkhwbeX92VNnyZRur59Z8Aezo 9w8DzCjZj75XfN961Qx5hKCdq00oaYdxdL1pEYKVP7BQfVtO4o0Ivkz5/WeLffG+NRGzFC eXOHo1vENV2i/7+5Z55dqdJ3V6L3ucKNkK7Jrg1A9C3Vu65de2sLgqGK3saY4s0rtamobJ adqPwUxl1GK77RFCYh7BfKZ2T3bb/0djgKfukRRkbETJTdnNvdEA6kRqfHP3QNVpLkA4qR Xl1FS/gMUuBX94cwyoFOcwzpxI0wyW4F+WzmUMoOQbW6NeJMiMyVD3zQHss+gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760139149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AREahMqdbiFQBxR4MPq42IpebJvtuCQBJg8DLd+RzhU=; b=FBGMuSj+m645m9uqktvj8umq1GafbL/gg+WlZ1G+GfF8ugQRMJwGgDDx89Jw6/+xeEzyC/ yln/pE2nBOnwuOyxISuVziV/MtRtHSuMbkRtEFHRCd5VrdxHyqQ0czVjcilw2v1AvGWxBO i+0Q9ZQMWiHXbEPOaopilgx16rmhN1JH0e9JHWu3vOQNOVwwmU08MunipnHEhOm9W//7Sr gURucbaFmFAY22roRy/9cTqtG0OiA1KxVqUNBUGmGk8CPbwNNkcd+d2giXPokWibWJeTlH 0ClGsXc5vBZVGY4hfuYU5/NvduIaNAhd0Ex4z8iHLiWC/92oZR9IUDiLlt+LcQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760139149; a=rsa-sha256; cv=none; b=xLAynEtv15Wdbk/ybqH6RXe1krw6hn68yaDGDHnLRwsBJgmy0ahuuLEddUdTxt8GSy9821 Ga6R+1/ccTmkmIFI1q+pUhi73sIaKAGnUVazIUg50HKLITv0paZfM6UfI5PGGBAMYoGCb0 oY4CskfpMOM59kJNuK0Z8QeTFSA58/04qgzVjqwn75VgeMXXl/PZiDCmr6R85HMGvBnRna Bomqn8iElhcCRyEhnl37i0P7ttla9s5fhSp64nHwL2Wvc1spxrZflU9lpJrBkJxD4sScyU kmNeYXvUgHuqWGonAcyRQYCNiszYv0+r7fsufTvUDtteJ7rYqWoK6jZ9w5xU6w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ck31n5x5Jz1MqS; Fri, 10 Oct 2025 23:32:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59ANWTgZ025115; Fri, 10 Oct 2025 23:32:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59ANWTmk025110; Fri, 10 Oct 2025 23:32:29 GMT (envelope-from git) Date: Fri, 10 Oct 2025 23:32:29 GMT Message-Id: <202510102332.59ANWTmk025110@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 7a289fe3cd5c - main - rpc.tlsservd.c: Pin max threads at 1 for now List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7a289fe3cd5c6de7ddbe394b7700b20b0bafdb3e Auto-Submitted: auto-generated The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=7a289fe3cd5c6de7ddbe394b7700b20b0bafdb3e commit 7a289fe3cd5c6de7ddbe394b7700b20b0bafdb3e Author: Rick Macklem AuthorDate: 2025-10-10 23:29:25 +0000 Commit: Rick Macklem CommitDate: 2025-10-10 23:29:25 +0000 rpc.tlsservd.c: Pin max threads at 1 for now PR#289734 reports a crash in tcp_use_close() when the rpc.tlsservd daemon is being used. Although I have no, as yet, had time to track down/fix the race, it turns out setting rpctls_maxthreads to 1 avoids the problem. This patch pins rpctls_maxthreads to 1 to avoid the problem, until there is a proper fix. PR: 289734 MFC after: 3 days --- usr.sbin/rpc.tlsservd/rpc.tlsservd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/usr.sbin/rpc.tlsservd/rpc.tlsservd.c b/usr.sbin/rpc.tlsservd/rpc.tlsservd.c index f07385a2baa7..fb0501b2db4c 100644 --- a/usr.sbin/rpc.tlsservd/rpc.tlsservd.c +++ b/usr.sbin/rpc.tlsservd/rpc.tlsservd.c @@ -168,7 +168,12 @@ main(int argc, char **argv) rpctls_verbose = false; ncpu = (u_int)sysconf(_SC_NPROCESSORS_ONLN); +#ifdef notnow rpctls_maxthreads = ncpu > 1 ? ncpu / 2 : 1; +#else + /* XXX For now, until fixed properly!! */ + rpctls_maxthreads = 1; +#endif while ((ch = getopt_long(argc, argv, "2C:D:dhl:N:n:mp:r:uvWw", longopts, NULL)) != -1) { @@ -199,6 +204,8 @@ main(int argc, char **argv) if (rpctls_maxthreads < 1 || rpctls_maxthreads > ncpu) errx(1, "maximum threads must be between 1 and " "number of CPUs (%d)", ncpu); + /* XXX For now, until fixed properly!! */ + rpctls_maxthreads = 1; break; case 'n': hostname[0] = '@';