From owner-freebsd-current@FreeBSD.ORG Tue Jun 10 13:01:46 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D0D31065679 for ; Tue, 10 Jun 2008 13:01:46 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from QMTA05.emeryville.ca.mail.comcast.net (qmta05.emeryville.ca.mail.comcast.net [76.96.30.48]) by mx1.freebsd.org (Postfix) with ESMTP id EE78F8FC1E for ; Tue, 10 Jun 2008 13:01:45 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from OMTA11.emeryville.ca.mail.comcast.net ([76.96.30.36]) by QMTA05.emeryville.ca.mail.comcast.net with comcast id cCdY1Z0060mlR8UA502700; Tue, 10 Jun 2008 13:01:45 +0000 Received: from mail.cokane.org ([24.60.133.163]) by OMTA11.emeryville.ca.mail.comcast.net with comcast id cD1j1Z00E3Xh0XL8XD1k8T; Tue, 10 Jun 2008 13:01:44 +0000 X-Authority-Analysis: v=1.0 c=1 a=CK24QABrBtkA:10 a=RwsSqX3J4hAA:10 a=6I5d2MoRAAAA:8 a=TtETrCVG_y5DVCwOYKIA:9 a=3OuCwejdIcDawJNCgZdIinUSv_oA:4 a=SV7veod9ZcQA:10 a=LY0hPdMaydYA:10 a=dRY_jfIhPTLdM5LfM4sA:9 a=pXdcOaGvBSqTx1rYpT6unYdlp3AA:4 a=rPt6xJ-oxjAA:10 Received: by mail.cokane.org (Postfix, from userid 103) id 6883B1DB2F9; Tue, 10 Jun 2008 09:01:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.20.1.3] (erwin.int.cokane.org [172.20.1.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cokane.org (Postfix) with ESMTP id 6FB7F1DB2FA; Tue, 10 Jun 2008 09:01:32 -0400 (EDT) From: Coleman Kane To: "Paul B. Mahol" In-Reply-To: <3a142e750806100556q546df348j4d5cb06bfe2bf286@mail.gmail.com> References: <1212870158.1724.25.camel@localhost> <3a142e750806071855wb9f4cddk9be25e8c0f3d4984@mail.gmail.com> <1213013020.25641.3.camel@localhost> <1213026755.1628.25.camel@localhost> <3a142e750806092016u34fcd515v7022aa6a0a034e17@mail.gmail.com> <1213101246.1588.5.camel@localhost> <3a142e750806100556q546df348j4d5cb06bfe2bf286@mail.gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-+WBVhbB3YOYOvScaEmdf" Organization: FreeBSD Project Date: Tue, 10 Jun 2008 08:59:46 -0400 Message-Id: <1213102786.1547.3.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 FreeBSD GNOME Team Port Cc: freebsd-current@freebsd.org, thompsa@freebsd.org Subject: Re: Call for Testers: Convert watchdog spinlock into a sleepable mutex in if_ndis X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2008 13:01:46 -0000 --=-+WBVhbB3YOYOvScaEmdf Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2008-06-10 at 14:56 +0200, Paul B. Mahol wrote: > On 6/10/08, Coleman Kane wrote: > > On Tue, 2008-06-10 at 05:16 +0200, Paul B. Mahol wrote: > >> On 6/9/08, Coleman Kane wrote: > >> > Ignore the previous patch (#2) and try this one instead: > >> > * > >> > http://people.freebsd.org/~cokane/patches/if_ndis-spinlock-to-mtx3.p= atch > >> > > >> > >> Fine for me, LOR appear any more. > > > > Thanks for the report. > > > >> > >> BTW: I'm dont like first line showing over and over again. It would be > >> nice > >> if that clueless message goes away. > > > > Is this a new message introduced with my changes? > No, it is not. Thanks for patch(es). >=20 I've got one more for you to try: * http://people.freebsd.org/~cokane/patches/if_ndis-spinlock-to-mtx4.= patch It removes the locking inside the ndis_tick function altogether, and just relies upon ndis_ticktask, ndis_resettask, and ndis_starttask to perform the appropriate locking (which they appear to have been written to do already). This might improve concurrency even more (and probably get rid of some mutex recursions). --=20 Coleman Kane --=-+WBVhbB3YOYOvScaEmdf Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkhOer0ACgkQcMSxQcXat5cLRACeJmvQJzzN88i1F0cCP43McnJB QgMAn3PelQMCM0EjcgVAHJdcWa9eMD+2 =vs6m -----END PGP SIGNATURE----- --=-+WBVhbB3YOYOvScaEmdf--