Date: Tue, 10 Jun 2008 08:59:46 -0400 From: Coleman Kane <cokane@FreeBSD.org> To: "Paul B. Mahol" <onemda@gmail.com> Cc: freebsd-current@freebsd.org, thompsa@freebsd.org Subject: Re: Call for Testers: Convert watchdog spinlock into a sleepable mutex in if_ndis Message-ID: <1213102786.1547.3.camel@localhost> In-Reply-To: <3a142e750806100556q546df348j4d5cb06bfe2bf286@mail.gmail.com> References: <1212870158.1724.25.camel@localhost> <3a142e750806071855wb9f4cddk9be25e8c0f3d4984@mail.gmail.com> <1213013020.25641.3.camel@localhost> <1213026755.1628.25.camel@localhost> <3a142e750806092016u34fcd515v7022aa6a0a034e17@mail.gmail.com> <1213101246.1588.5.camel@localhost> <3a142e750806100556q546df348j4d5cb06bfe2bf286@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-+WBVhbB3YOYOvScaEmdf Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2008-06-10 at 14:56 +0200, Paul B. Mahol wrote: > On 6/10/08, Coleman Kane <cokane@freebsd.org> wrote: > > On Tue, 2008-06-10 at 05:16 +0200, Paul B. Mahol wrote: > >> On 6/9/08, Coleman Kane <cokane@freebsd.org> wrote: > >> > Ignore the previous patch (#2) and try this one instead: > >> > * > >> > http://people.freebsd.org/~cokane/patches/if_ndis-spinlock-to-mtx3.p= atch > >> > > >> > >> Fine for me, LOR appear any more. > > > > Thanks for the report. > > > >> > >> BTW: I'm dont like first line showing over and over again. It would be > >> nice > >> if that clueless message goes away. > > > > Is this a new message introduced with my changes? > No, it is not. Thanks for patch(es). >=20 I've got one more for you to try: * http://people.freebsd.org/~cokane/patches/if_ndis-spinlock-to-mtx4.= patch It removes the locking inside the ndis_tick function altogether, and just relies upon ndis_ticktask, ndis_resettask, and ndis_starttask to perform the appropriate locking (which they appear to have been written to do already). This might improve concurrency even more (and probably get rid of some mutex recursions). --=20 Coleman Kane --=-+WBVhbB3YOYOvScaEmdf Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkhOer0ACgkQcMSxQcXat5cLRACeJmvQJzzN88i1F0cCP43McnJB QgMAn3PelQMCM0EjcgVAHJdcWa9eMD+2 =vs6m -----END PGP SIGNATURE----- --=-+WBVhbB3YOYOvScaEmdf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1213102786.1547.3.camel>