From owner-freebsd-current@freebsd.org Wed Aug 14 20:19:35 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CB84BB9940 for ; Wed, 14 Aug 2019 20:19:35 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4681CC51qjz3PgQ for ; Wed, 14 Aug 2019 20:19:35 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id AC36EB993E; Wed, 14 Aug 2019 20:19:35 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ABECCB9939 for ; Wed, 14 Aug 2019 20:19:35 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4681CC39Jqz3PgP for ; Wed, 14 Aug 2019 20:19:35 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1565813974; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=jBtTurwAk+TGEX5O672vQ4Nq07LKAS453xWtkDaG25L1O+qSZogHhKXKxRT+7Jrdg6Hbr5ej55vPm TvJ1rUFzUPTjjiwtDoC7Ha3/tD/zBv8ff6cBWPZe338v0Ul7012rptRAzMamol5NSnzJShoZEreT2w ERZcVlUFxIzxRozuXKShdHhJsILiV67tSfkP6ACiuhGliSFdUICCf5sUwZAAk6qj7ImoFT4LVKM5NL a4ijxEd9SxYKpZsSp8x+g16M9Q1OkQib9KwL06tXyQmtDQwZu3vtvxrdYeJTl3o0QEUs9WLPH1WIan l6GvmprEYFoX/91qjuGFVX2Y3VBd80g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=VU2DFjXf+s5TXDllr7wFD+mLArls6pSWOl7kAIX9Q0A=; b=QmgY0HkEXO+LlluVhXQc4UpblJAumwJzABgkfIAbfjTDUHmns8cKe19CbUWpUahP5vgRumBsf4k5u jNfP56wm/b8yiyIuafwq0LXYwsh/iKJ8zYDkX8WNQ8xQktOanJo79ILj6RoRAKXa+WPSHnaoQoOLdW 0EW3n7E6BVrI0iRGmfqIV/mvZ/AkE9Rp0QY8ct6+PA3eMkMUjkJmGRtX3MbsRT3HyR2/elJtnCQrFX Gs9D5q1VjQ/bcpYJjCw+tpvIH3wg0WWlkk8kIdc7WDvRJkLMnGoB3AfAYct/PRgPjPEFjgU11+Nq7U OzwaHj/6/lDAD0k0B1JSiUOny2PUk/A== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=VU2DFjXf+s5TXDllr7wFD+mLArls6pSWOl7kAIX9Q0A=; b=jOB3+jzIq0o/NmteTsPI+qFn966j3CusgAvO4LsKIISkE3npHqP/HynDWeOOiW69yNRm1wz6A3uNv LwhsFTa14YwduHaJv8CY3Fy9wnnBoqWoLrbohotKtoK1OxPs+69MOTvdmdvzOGGb18PEMJOvTvgKNp 0CPp+SsZQp4LgHiqcBDiV9414HtgjCXMGhzFPEMZzmfafeOf3KlicmwfMILBuzhDiEXaSCQ1467CN+ foNrbQFec5bzkFX5ELDg1H65VKF/9KSqpEKISlJp7pWYn0Cf1Xm5mqCpMPmVT94PAGrFnh36PkA7JR jKGfVW4sp5yNl5pGvZXn+4c92WOGYMw== X-MHO-RoutePath: aGlwcGll X-MHO-User: d351da40-bed0-11e9-b67b-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id d351da40-bed0-11e9-b67b-cdd75d6ce7a8; Wed, 14 Aug 2019 20:19:33 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x7EKJVW9055856; Wed, 14 Aug 2019 14:19:31 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: HEADSUP: drm-current-kmod now installs sources From: Ian Lepore To: Warner Losh Cc: John Baldwin , Kyle Evans , x11@freebsd.org, current , Niclas Zeising Date: Wed, 14 Aug 2019 14:19:31 -0600 In-Reply-To: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> <02c501907f6eca8f4bd9b44331ac6ab2e28d624f.camel@freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4681CC39Jqz3PgP X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 20:19:35 -0000 On Wed, 2019-08-14 at 13:59 -0600, Warner Losh wrote: > On Wed, Aug 14, 2019 at 1:56 PM Ian Lepore wrote: > > > On Wed, 2019-08-14 at 12:00 -0700, John Baldwin wrote: > > > On 8/14/19 11:06 AM, Kyle Evans wrote: > > > > LOCAL_MODULES="" does seem like a sensible default when we're > > > > not > > > > building a native kernel. > > > > > > Unfortunately kern.post.mk has no way of knowing that as > > > MACHINE_* > > > are already set to the TARGET_* values by the time this target is > > > invoked. Also, the 'make tinderbox' use case is a legit use case > > > that some folks want (for CI, etc.) > > > > > > > BUILDHOST_ARCH!= uname -p > > .if ${BUILDHOST_ARCH} != ${TARGET_ARCH} > > > > Unfortunately, I don't think it's as easy to compare the buildhost > > running version with the version of source being built, unless the > > build is started from the top level so that Makefile.inc1 sets the > > variables. > > > > We already know MACHINE_ARCH != TARGET_ARCH in Makefile.inc1 and > already do > different things based on it. But to be honest, I'd think there'd be > times > I'd absolutely want to build them all, and other times I wouldn't > which > strongly suggests some kind of knob specific for cross building the > port/pkg-based kernel modules. We could then pass that knob into the > kernel > builds which would then not try to guess whether or not to build > LOCAL_MODULES... > > This is just about AUTOMATICALLY deciding to build something, based on the presence of source code in an arbitrary fixed location outside of the source tree on the build machine. Anything set by the user should be honored without question, including LOCAL_MODULES. My point is only that the build machinery should not be deciding to build something the user didn't specify based on the existence of out- of-tree files on the build machine (I'd like to put the period right here in this sentence), unless there's a very high likelyhood that the build being done is for the build machine. Things like CI that want to include more than in-tree sources as part of the build should be handling that by setting appropriate knobs as part of invoking the build. -- Ian