From owner-freebsd-python@freebsd.org Thu Sep 12 23:51:28 2019 Return-Path: Delivered-To: freebsd-python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A4D05DE43B for ; Thu, 12 Sep 2019 23:51:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46TwXJ3qjTz3QN7 for ; Thu, 12 Sep 2019 23:51:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 836DBDE43A; Thu, 12 Sep 2019 23:51:28 +0000 (UTC) Delivered-To: python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8331BDE439 for ; Thu, 12 Sep 2019 23:51:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46TwXJ2v1vz3QN4 for ; Thu, 12 Sep 2019 23:51:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2E921266FF for ; Thu, 12 Sep 2019 23:51:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8CNpS5w032191 for ; Thu, 12 Sep 2019 23:51:28 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8CNpSjj032188 for python@FreeBSD.org; Thu, 12 Sep 2019 23:51:28 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 240476] security/py-fido2: Add FreeBSD support Date: Thu, 12 Sep 2019 23:51:28 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-qa X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: grembo@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Sep 2019 23:51:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240476 --- Comment #13 from Michael Gmelin --- (In reply to Kubilay Kocak from comment #1) Thanks for your response and the clear instructions Kubilay. > - Confirm the changes pass QA (portlint, poudriere) Confirmed, please find attached the output of `poudriere testport security/py-fido2' runs for various combinations of releases and architectu= res. portlint -a is happy (output also attached). > - If there's a test suite for fido2, confirm it passes with this patch (a= nd adding TEST_DEPENDS / test: target support to port) The test suite didn't work, as it would unconditionally import all test sources, including the linux tests, which require pyfakefs, which isn't available in ports (I tried a quick port, but it's quite linux specific and would've required even more work, just to support a unit test that won't run anyway). To fix this, setup.py now uses pytest, which allows exclusion of f= iles in conftest.py (also gets rid of "you're not on darwin" warnings). Test target support is now in the port skeleton, so `make test' does the Ri= ght Thing(tm). I also added unit tests for the FreeBSD specific bits and ran `m= ake test' in all the poudriere combinations mentioned above manually (using a s= hell after invoking `poudriere testport -i'). > - Submit the patches in an upstream PR and add the PR title/URL as a comm= ent in the patch header To to so, some more work was necessary (like adding FreeBSD unit tests, changing readme, etc.). You can find the pull request here https://github.com/Yubico/python-fido2/pull/64 > Also, could you register/publish uhid-freebsd (under that name) in PyPI, = so that upstream can depend on it in setup.py:install_requires using an env= ironment marker ; sys_platform =3D=3D 'freebsd' PyPI account created and package published (https://pypi.org/project/uhid-freebsd/). devel/py-freebsd-uhid now pulls f= rom there instead of github. Anything else? --=20 You are receiving this mail because: You are the assignee for the bug.=