From owner-svn-ports-all@freebsd.org  Fri Apr  7 20:53:28 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 70892D332D9;
 Fri,  7 Apr 2017 20:53:28 +0000 (UTC)
 (envelope-from rezny@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 53ADE833;
 Fri,  7 Apr 2017 20:53:28 +0000 (UTC)
 (envelope-from rezny@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1406)
 id 85A535640; Fri,  7 Apr 2017 20:53:27 +0000 (UTC)
From: Matthew Rezny <rezny@freebsd.org>
To: Jan Beich <jbeich@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r437953 - in head/lang/beignet: . files
Date: Fri, 07 Apr 2017 22:53:27 +0200
Message-ID: <24496938.jsC6qZ9reS@workstation.reztek>
Organization: FreeBSD
User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.30; amd64; ; )
In-Reply-To: <a87s-otl5-wny@FreeBSD.org>
References: <201704071930.v37JUBGj017948@repo.freebsd.org>
 <a87s-otl5-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Apr 2017 20:53:28 -0000

On Friday 07 April 2017 22:23:18 Jan Beich wrote:
> Matthew Rezny <rezny@FreeBSD.org> writes:
> >   - Enable OpenCL 2.0 on AMD64
> 
> Isn't this premature before 1.3.2 or bug 217635 fix?
> 
There was no clear answer given in that PR as to whether or not version 1.3.1 
addressed the issue, but as I understood it the issue in that PR was caused by 
a lack of OpenCL 2.0 so I do not see how enabling it would be premature.

> > +USE_LDCONFIG=	${LOCALBASE}/lib/${PORTNAME}
> 
> Why do you need ldconfig hints for dlopen(3)? libcl.so embeds absolute
> paths for libgbe.so and libgbeinterp.so + absolute path via ocl-icd
> config in /usr/local/etc/OpenCL/vendors/intel-beignet.icd
> 
> Please, don't turn portlint into a cargo cult.
> 
Nothing to do with portlint, just following what is written in the Porter's 
Handbook about ports that install shared libraries and USE_LDCONFIG.

> > +LLVMVER=	${MESA_LLVM_VER:U39}
> 
> Why not drop LLVMVER variable and use MESA_LLVM_VER directly?
> 
>   BUILD_DEPENDS=	clang${MESA_LLVM_VER}:devel/llvm${MESA_LLVM_VER} \
>   [...]
>   MESA_LLVM_VER?=	39

Conversely, why do it that way? I see no benefit, just more lines changed.