Date: Fri, 20 Feb 2015 13:12:27 +0000 From: "onwahe-gmail-com (Svatopluk Kraus)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Changed Subscribers] D1912: Fix endianness on FDT read in ARM GIC Message-ID: <dd77d3b57d37baea10833c8da663fdae@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-ker5chhmevh5hyis4d47-req@FreeBSD.org> References: <differential-rev-PHID-DREV-ker5chhmevh5hyis4d47-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
onwahe-gmail-com added a subscriber: onwahe-gmail-com. onwahe-gmail-com added a comment. In fact, the opposite is correct. In present, the arguments passed to function are already in suitable format. So, all fdt32_to_cpu() calls should be removed. I remembered some debate with Michal about that that only consumer knows what kind of data come to him, so decoding should be done on his side entirely. However, in current tree, the data are decoded in ofw_bus_intr_to_rl(). REVISION DETAIL https://reviews.freebsd.org/D1912 To: zbb, imp, andrew Cc: onwahe-gmail-com, freebsd-arm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dd77d3b57d37baea10833c8da663fdae>