From owner-freebsd-arm@FreeBSD.ORG Fri Feb 20 13:12:28 2015 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 02021D41 for ; Fri, 20 Feb 2015 13:12:28 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D5908898 for ; Fri, 20 Feb 2015 13:12:27 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1KDCRD0007933 for ; Fri, 20 Feb 2015 13:12:27 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1KDCRG9007932; Fri, 20 Feb 2015 13:12:27 GMT (envelope-from root) Date: Fri, 20 Feb 2015 13:12:27 +0000 To: freebsd-arm@freebsd.org From: "onwahe-gmail-com (Svatopluk Kraus)" Subject: [Differential] [Changed Subscribers] D1912: Fix endianness on FDT read in ARM GIC Message-ID: X-Priority: 3 Thread-Topic: D1912: Fix endianness on FDT read in ARM GIC X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YmE3NzVmMjk2ZDk4MjdlMDE0NzYyNDAwMDVmIFTnMrs= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 13:12:28 -0000 onwahe-gmail-com added a subscriber: onwahe-gmail-com. onwahe-gmail-com added a comment. In fact, the opposite is correct. In present, the arguments passed to function are already in suitable format. So, all fdt32_to_cpu() calls should be removed. I remembered some debate with Michal about that that only consumer knows what kind of data come to him, so decoding should be done on his side entirely. However, in current tree, the data are decoded in ofw_bus_intr_to_rl(). REVISION DETAIL https://reviews.freebsd.org/D1912 To: zbb, imp, andrew Cc: onwahe-gmail-com, freebsd-arm